-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes settings to management #7284
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
91b6d92
Changes settings to management
b43ac4c
Refactor management styles for less specificity.
cjcenizal 0ac1c8c
Changes MangementSection.get{,Section}
8e69ed2
Maintain section selection for child pages
78e96f9
Removes title on Indicies as it's represented in the sub-nav
5e237cb
Fixes styling for Saved Object page
727bc0c
Improves documentation for ManagementSection
90bffc5
Moves index creation to management/data/index
fb313cd
Prevents linking to last sub-url for Management
96bf222
Loads default index instead of preforming a redirect
01d56e2
Quotes directive argument
b21cf83
Resolves indexPatternIds for /management/data path
65b0de7
Labels Kibana's settings as "Advanced Settings"
56d03d9
Don't require /management/data for existing indicies
725c2c1
Addresses ManagementSection test feedback
3ec1c51
Removes duplicate indexPatternIds resolution
5223800
Correctly route to add index page on deletion
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<div class="app-container"> | ||
<nav class="navbar navbar-default navbar-static-top subnav" data-test-subj="managementNav"> | ||
<bread-crumbs omit-current-page="true"></bread-crumbs> | ||
|
||
<ul class="nav navbar-nav"> | ||
<li class="current-page" ng-hide="sectionName"> | ||
{{::section.display}} | ||
</li> | ||
|
||
<li | ||
ng-if="sectionName" | ||
ng-repeat="item in section.items.inOrder" | ||
ng-class="item.class"> | ||
|
||
<a class="navbar-link" kbn-href="{{::item.url}}" data-test-subj="{{::item.name}}"> | ||
{{::item.display}} | ||
</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
|
||
<div role="main" class="management-container" ng-transclude></div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import _ from 'lodash'; | ||
|
||
import 'plugins/kibana/management/sections'; | ||
import 'plugins/kibana/management/styles/main.less'; | ||
import 'ui/filters/start_from'; | ||
import 'ui/field_editor'; | ||
import 'plugins/kibana/management/sections/indices/_indexed_fields'; | ||
import 'plugins/kibana/management/sections/indices/_scripted_fields'; | ||
import 'ui/directives/bread_crumbs'; | ||
import uiRoutes from 'ui/routes'; | ||
import uiModules from 'ui/modules'; | ||
import appTemplate from 'plugins/kibana/management/app.html'; | ||
import landingTemplate from 'plugins/kibana/management/landing.html'; | ||
import chrome from 'ui/chrome/chrome'; | ||
import management from 'ui/management'; | ||
|
||
uiRoutes | ||
.when('/management', { | ||
template: landingTemplate | ||
}); | ||
|
||
require('ui/index_patterns/route_setup/load_default')({ | ||
notRequiredRe: /^\/management\/data\//, | ||
whenMissingRedirectTo: '/management/data/index' | ||
}); | ||
|
||
uiModules | ||
.get('apps/management') | ||
.directive('kbnManagementApp', function (Private, $route, $location, timefilter, buildNum, buildSha) { | ||
return { | ||
restrict: 'E', | ||
template: appTemplate, | ||
transclude: true, | ||
scope: { | ||
sectionName: '@section' | ||
}, | ||
|
||
link: function ($scope) { | ||
timefilter.enabled = false; | ||
$scope.sections = management.items.inOrder; | ||
$scope.section = management.getSection($scope.sectionName) || management; | ||
|
||
if ($scope.section) { | ||
$scope.section.items.forEach(item => { | ||
item.class = `#${$location.path()}`.indexOf(item.url) > -1 ? 'active' : undefined; | ||
}); | ||
} | ||
|
||
management.getSection('kibana').info = `Build ${buildNum}, Commit SHA ${buildSha.substr(0, 8)}`; | ||
} | ||
}; | ||
}); | ||
|
||
uiModules | ||
.get('apps/management') | ||
.directive('kbnManagementLanding', function (kbnVersion) { | ||
return { | ||
restrict: 'E', | ||
link: function ($scope) { | ||
$scope.sections = management.items.inOrder; | ||
$scope.kbnVersion = kbnVersion; | ||
} | ||
}; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
<kbn-management-app> | ||
<kbn-management-landing> | ||
<div class="product-overview"> | ||
<span class="kibana-version">Version: {{::kbnVersion}}</span> | ||
</div> | ||
<div class="management-sections"> | ||
<div | ||
ng-if="section.items.length > 0" | ||
ng-repeat="section in sections" | ||
ng-class="{ 'management-section-info-expanded': section.showInfo }" | ||
class="col-xs-12 management-section management-section-{{::section.id}}"> | ||
|
||
<div class="panel panel-product management-panel-product"> | ||
<div class="panel-heading panel-heading-{{::section.id}}"> | ||
{{::section.display}} | ||
|
||
<i | ||
class="fa fa-info-circle pull-right panel-heading-icon" | ||
ng-click="section.showInfo = !!!section.showInfo" | ||
ng-if="section.info"> | ||
</i> | ||
</div> | ||
|
||
<div class="panel-body"> | ||
<div class="row"> | ||
<ul class="management-section-items list-unstyled"> | ||
<li | ||
class="col-xs-4 col-md-3" | ||
ng-repeat="item in section.items.inOrder"> | ||
|
||
<a class="management-link" kbn-href="{{::item.url}}"> | ||
{{::item.display}} | ||
</a> | ||
</li> | ||
</ul> | ||
</div> | ||
<div class="management-section-info"> | ||
{{::section.info}} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</kbn-management-landing> | ||
</kbn-management-app> |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import 'plugins/kibana/management/sections/settings'; | ||
import 'plugins/kibana/management/sections/objects'; | ||
import 'plugins/kibana/management/sections/indices'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God, thank you for this. Haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LukasYouAreVeryWelcomeForThisLittleGemOfAVariableName