[Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist #71807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
peluja1012
added
release_note:skip
dplumlee
approved these changes
Jul 15, 2020
spong
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Checked out, tested locally, and LGTM! Saw the empty modal bug around exception creation (and refresh solved it), but that's known and being tracked so nothing to hold this up. Thanks @peluja1012! Excited to start testing all these new features! 🙂 🧪 🚀
peluja1012
force-pushed
the
exception-modal-exception-list-api
branch
from
771117e
to
39d6c32
Compare
peluja1012
changed the title
|
@elasticmachine merge upstream |
peluja1012
force-pushed
the
exception-modal-exception-list-api
branch
from
1269d23
to
88ec097
Compare
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
angorayc
pushed a commit
to angorayc/kibana
that referenced
this pull request
Jul 15, 2020
…f it doesn't already exist (elastic#71807) * use createEndpointList api * fix lint * update list id constant * add schema test * add api test
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to the Exception Modal and endpoint exceptions. When the user adds an endpoint exception, the exception modal will try to create the global endpoint exception list if it doesn't already exist. If it already exists, it will fetch it. This PR makes use of the API's specific to endpoint exception lists that are exposed by this PR #71792.
Checklist
Delete any items that are not applicable to this PR.
For maintainers