[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow #70208

kevinlog · 2020-06-29T14:40:22Z

Summary

Reassignment link:

Agent details with Config reassign link search param:

This PR adjusts the reassignment link to include the Agent ID and sends users to the Agent details UI. It also opens the reassignment flyout upon navigation. When users complete the flow, they will return the Host list with Host details section open on the Endpoint side.

Ingest changes:

uses patterns first established here [Endpoint] Add Endpoint empty states for onboarding #69626
allows us to open Reassignment flyout via URL search param, openReassignFlyout
establishes a roundtrip for the Reassignment flow

Security app changes:

sets up roundtrip links
adjust Reassignment link to use openReassignFlyout search param

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-06-29T15:50:34Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-06-29T15:50:43Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-06-29T16:42:28Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

nchaulet

Work as expected

parkiino · 2020-06-29T22:03:37Z

x-pack/plugins/ingest_manager/public/applications/ingest_manager/types/intra_app_route_state.ts

@@ -29,9 +29,18 @@ export interface AgentConfigDetailsDeployAgentAction {
  onDoneNavigateTo?: Parameters<ApplicationStart['navigateToApp']>;
 }

+/**
+ * Supported routing state for the agent config details page routes with deploy agents action


So is this file where all of the round trips are registered basically?

this is where you define the types for which actions a page will support

EDIT:
This line is where you define each callback https://github.com/elastic/kibana/pull/70208/files#diff-a3e3c11e8b58a9e2af3af104ab58a81dR110

parkiino · 2020-06-29T22:09:46Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx

+    it('should include the link to reassignment in Ingest', async () => {
+      coreStart.application.getUrlForApp.mockReturnValue('/app/ingestManager');
+      const renderResult = render();
+      const linkToLogs = await renderResult.findByTestId('hostDetailsLinkToIngest');


probs want to rename this const to linkToIngest or something

you are correct, updated to have a name that makes sense

parkiino · 2020-06-29T22:19:33Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx

+        });
+      });
+
+      it('should navigate to logs without full page refresh', () => {


wait can you take out logs here in the title too 🙏

kevinlog · 2020-06-30T00:01:37Z

@elasticmachine merge upstream

kibanamachine · 2020-06-30T01:43:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 413bf37

Build metrics

✅ unchanged

History

💔 Build #57355 failed 507c7d1
💚 Build #57278 succeeded 6584b38
💚 Build #57194 succeeded 24c31dc
💚 Build #57165 succeeded eabf90b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ata-streams * 'master' of github.com:elastic/kibana: (50 commits) [Logs UI] [Alerting] "Group by" functionality (elastic#68250) [Discover] Deangularize Skip to bottom button (elastic#69811) Implement recursive plugin discovery (elastic#68811) Use ts-expect-error in platform code (elastic#69883) [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208) [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603) [ILM] Fix bug when clearing priority field (elastic#70154) [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139) [IngestManager] Allow to filter agent by packages (elastic#69731) [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199) [Metrics UI] UX improvements for saved views (elastic#69910) [APM] docs: unique transaction troubleshooting (elastic#69831) Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007) [Maps] choropleth layer wizard (elastic#69699) Make custom errors by extending Error (elastic#69966) [Ingest Manager] Support updated package output structure (elastic#69864) Resolver test coverage (elastic#70246) Async Discover search test (elastic#64388) [ui-shared-deps] include styled-components (elastic#69322) ... # Conflicts: # x-pack/plugins/snapshot_restore/server/types.ts

…bana into alerting/consumer-based-rbac * 'alerting/consumer-based-rbac' of github.com:gmmorris/kibana: (49 commits) [Discover] Deangularize Skip to bottom button (elastic#69811) Implement recursive plugin discovery (elastic#68811) Use ts-expect-error in platform code (elastic#69883) [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208) [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603) [ILM] Fix bug when clearing priority field (elastic#70154) [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139) [IngestManager] Allow to filter agent by packages (elastic#69731) [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199) [Metrics UI] UX improvements for saved views (elastic#69910) [APM] docs: unique transaction troubleshooting (elastic#69831) Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007) [Maps] choropleth layer wizard (elastic#69699) Make custom errors by extending Error (elastic#69966) [Ingest Manager] Support updated package output structure (elastic#69864) Resolver test coverage (elastic#70246) Async Discover search test (elastic#64388) [ui-shared-deps] include styled-components (elastic#69322) SECURITY-ENDPOINT: add host properties (elastic#70238) ...

…dd roundtrip to Reassignment flow (#70208) (#70281)

…dd roundtrip to Reassignment flow (elastic#70208)

kevinlog added 2 commits June 29, 2020 10:38

adjust reassign link, add roundtrip

eabf90b

add UT for reassignment link

24c31dc

kevinlog changed the title ~~adjust reassign link, add roundtrip~~ [SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow Jun 29, 2020

kevinlog changed the title ~~[SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow~~ [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow Jun 29, 2020

kevinlog marked this pull request as ready for review June 29, 2020 15:50

kevinlog requested a review from a team as a code owner June 29, 2020 15:50

kevinlog requested a review from a team June 29, 2020 15:50

kevinlog requested a review from a team as a code owner June 29, 2020 15:50

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 29, 2020

kevinlog added the Team:Endpoint Management label Jun 29, 2020

kevinlog added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.9.0 Feature:Endpoint Elastic Endpoint feature labels Jun 29, 2020

clean up

6584b38

nchaulet approved these changes Jun 29, 2020

View reviewed changes

parkiino reviewed Jun 29, 2020

View reviewed changes

correct variable names

a8d49c2

parkiino reviewed Jun 29, 2020

View reviewed changes

text adjustment

507c7d1

parkiino approved these changes Jun 29, 2020

View reviewed changes

Merge branch 'master' into task/reassign-query-params

413bf37

kevinlog merged commit b3f19da into elastic:master Jun 30, 2020

kevinlog deleted the task/reassign-query-params branch June 30, 2020 01:43

kevinlog mentioned this pull request Jun 30, 2020

[7.x] [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (#70208) #70281

Merged

kevinlog added a commit that referenced this pull request Jun 30, 2020

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and a…

b48829c

…dd roundtrip to Reassignment flow (#70208) (#70281)

Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and a…

2c83411

…dd roundtrip to Reassignment flow (elastic#70208)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow #70208

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow #70208

kevinlog commented Jun 29, 2020 •

edited

Loading

elasticmachine commented Jun 29, 2020

elasticmachine commented Jun 29, 2020

elasticmachine commented Jun 29, 2020

nchaulet left a comment

parkiino Jun 29, 2020

kevinlog Jun 29, 2020 •

edited

Loading

parkiino Jun 29, 2020

parkiino Jun 29, 2020

kevinlog Jun 29, 2020

parkiino Jun 29, 2020

kevinlog Jun 29, 2020

kevinlog commented Jun 30, 2020

kibanamachine commented Jun 30, 2020

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow #70208

[Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow #70208

Conversation

kevinlog commented Jun 29, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 29, 2020

elasticmachine commented Jun 29, 2020

elasticmachine commented Jun 29, 2020

nchaulet left a comment

Choose a reason for hiding this comment

parkiino Jun 29, 2020

Choose a reason for hiding this comment

kevinlog Jun 29, 2020 • edited Loading

Choose a reason for hiding this comment

parkiino Jun 29, 2020

Choose a reason for hiding this comment

parkiino Jun 29, 2020

Choose a reason for hiding this comment

kevinlog Jun 29, 2020

Choose a reason for hiding this comment

parkiino Jun 29, 2020

Choose a reason for hiding this comment

kevinlog Jun 29, 2020

Choose a reason for hiding this comment

kevinlog commented Jun 30, 2020

kibanamachine commented Jun 30, 2020

💚 Build Succeeded

Build metrics

History

kevinlog commented Jun 29, 2020 •

edited

Loading

kevinlog Jun 29, 2020 •

edited

Loading