[Dashboard] Refresh container after clone panel is complete #65252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
v7.8.0
v8.0.0
release_note:skip
majagrubic
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
May 5, 2020
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
May 5, 2020
majagrubic
pushed a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #64521
It's possible that the values in the visualization changed since the last dashboard refresh, so when cloning the panel the values would be in discrepancy, as described in the issue above. This small fix causes the dashboard container to refresh, syncing the values after the clone is complete:
I tested this by loading the dashboard and then updating the necessary values in ES from dev console, eg:
and then cloning the panel.
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers