Implements a pattern checker directive for use in the Add Data UI #6493
Conversation
| }; | ||
|
|
||
| this.validateInstall = () => { | ||
| es.count({ |
There was a problem hiding this comment.
We want to eventually get the es client out of the frontend.
Can we make this a REST endpoint?
There was a problem hiding this comment.
@rashidkpc I asked myself the same question, I didn't know if it made sense for something so simple but if we really want to eliminate the ES client completely then I guess it does.
Any opinions on what the endpoint for such an API should be? I could see any of the following being viable options:
localhost:5601/api/kibana/{indexPatternId}/_count
(mirrors ES syntax)
localhost:5601/api/kibana/ingest/{indexPatternId}/_count
(with the ingest API we've sort of established the ingest config as a higher level concept than an index pattern, so maybe it belongs under ingest?)
localhost:5601/api/kibana/index_patterns/{indexPatternId}/_count
(this one feels weird but I include it because it's a way to namespace the API without re-using ingest)
Something else?
There was a problem hiding this comment.
I like the first one, i don't think it belongs under ingest
|
I'd get rid of both the "Validating" and "Done" buttons here and make them one big disabled button with the text "Waiting for data ..." and just go ahead and start the looper immediately. Then when you see data change the button to green with a big "Success!" and the text "click to above to continue". Or something like that. Under the big "Waiting for data" button you can stick a small link that says "Skip this step" for folks who don't need your help watching for documents. |
|
Once #6534 is merged I'll rebase this and then it'll be ready for another look. |
Bargs
force-pushed
the
ingest/filebeatVerify
branch
from
9e1879c
to
3127348
Compare
|
I've addressed all the feedback, but #6553 needs to be merged before this branch can be fully tested. Instead of creating a disabled button that says "waiting for data", I just removed the button entirely and added an extra step to the instructions explaining that we're polling the index pattern and that they can skip the step by simply clicking the existing "Done" button if they want to. |
Bargs
force-pushed
the
ingest/filebeatVerify
branch
from
3127348
to
7cc4945
Compare
|
@rashidkpc ready for another look. |
|
Needs tests, but otherwise GTG |
Bargs
force-pushed
the
ingest/filebeatVerify
branch
from
838284b
to
0893115
Compare
|
jenkins, test it |
…e filebeat installation instructions
Bargs
force-pushed
the
ingest/filebeatVerify
branch
from
0893115
to
615560f
Compare
|
Tests added and build is finally green after merging master a few times, ready for one more look @rashidkpc |
|
LGTM |
Implements a pattern checker directive for use in the Add Data UI
Related to #5974
Provides a re-useable directive for checking the document count of a given index pattern. Intended for use on the final step of add data wizards so that the user can verify that their filebeat/topbeat/foobeat install is working.