Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Fixes for editing alerts in alert management #64597
[Metrics UI] Fixes for editing alerts in alert management #64597
Changes from 1 commit
c3e2765
0db04a7
b5ca754
b82e9de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's actually a bug in the underlying alert library that won't let us
setAlertParams('groupBy', undefined)
, so this is causing a bug with clearing out the group by field in edit. We should update:kibana/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
Lines 151 to 152 in 0db04a7
setAlertParams('groupBy', group || '');
.The bug in alerting is here:
kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_reducer.ts
Lines 78 to 95 in daf6226