Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NP] Inline buildPointSeriesData and buildHierarchicalData dependencies #61575

Merged
merged 38 commits into from
Apr 9, 2020
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7fafc54
Move buildHierarchicalData to vislib
maryia-lapata Mar 27, 2020
4cd75d1
Move shortened version of buildPointSeriesData to Discover
maryia-lapata Mar 27, 2020
2bc346b
Move buildPointSeriesData to vis_type_vislib
maryia-lapata Mar 27, 2020
ba83566
Convert unit tests to jest
maryia-lapata Mar 30, 2020
8283cad
Remove ui/agg_response
maryia-lapata Mar 30, 2020
45b33f8
Merge remote-tracking branch 'remotes/kibana/master' into agg-respons…
maryia-lapata Mar 30, 2020
6d3b22e
Convert point_series files to TS
maryia-lapata Mar 31, 2020
2020a63
Update TS in unit tests
maryia-lapata Apr 1, 2020
9c2cc97
Merge branch 'master' into agg-response-cleanup
elasticmachine Apr 1, 2020
d05da68
Convert buildHierarchicalData to TS
maryia-lapata Apr 2, 2020
8e39fbd
Convert buildPointSeriesData to TS in Discover
maryia-lapata Apr 2, 2020
abcc032
Clean TS in Discover
maryia-lapata Apr 3, 2020
f7609a4
Update TS for buildHierarchicalData
maryia-lapata Apr 3, 2020
4eb83d9
Update buildHierarchicalData unit tests
maryia-lapata Apr 3, 2020
994b93e
Clean up TS in point_series
maryia-lapata Apr 3, 2020
207d32c
Merge branch 'master' into agg-response-cleanup
elasticmachine Apr 3, 2020
3de79f7
Add unit tests fro response_handler.js
maryia-lapata Apr 4, 2020
76f0266
Simplify point_series for Discover
maryia-lapata Apr 4, 2020
5bd3a5d
Return array for data
maryia-lapata Apr 6, 2020
f610ffd
Merge branch 'master' into agg-response-cleanup
elasticmachine Apr 6, 2020
15af087
Add check for empty row
maryia-lapata Apr 6, 2020
da332e0
Merge branch 'agg-response-cleanup' of https://github.com/maryia-lapa…
maryia-lapata Apr 6, 2020
f6a4ed5
Simplify point_series for Discover
maryia-lapata Apr 6, 2020
84fdace
Merge branch 'master' into agg-response-cleanup
elasticmachine Apr 6, 2020
bbc4624
Return all points
maryia-lapata Apr 6, 2020
e7c88f6
Merge remote-tracking branch 'kibana/master' into agg-response-cleanup
maryia-lapata Apr 6, 2020
ad8ab46
Merge remote-tracking branch 'kibana/master' into agg-response-cleanup
maryia-lapata Apr 8, 2020
10eca3f
Specify TS
maryia-lapata Apr 8, 2020
a72aa56
Merge branch 'agg-response-cleanup' of https://github.com/maryia-lapa…
maryia-lapata Apr 8, 2020
1168932
Refactoring
maryia-lapata Apr 8, 2020
acef340
Merge remote-tracking branch 'upstream/master' into agg-response-cleanup
flash1293 Apr 9, 2020
b0d9e60
Merge remote-tracking branch 'kibana/master' into agg-response-cleanup
maryia-lapata Apr 9, 2020
16028af
Merge remote-tracking branch 'kibana/master' into agg-response-cleanup
maryia-lapata Apr 9, 2020
5617d0c
Simplifying
maryia-lapata Apr 9, 2020
c0d6422
Merge branch 'agg-response-cleanup' of github.com:maryia-lapata/kiban…
flash1293 Apr 9, 2020
5f7b63e
improve types
flash1293 Apr 9, 2020
d7e5043
Merge pull request #12 from flash1293/agg-response-cleanup-types
maryia-lapata Apr 9, 2020
838f5cf
Update _get_point.test.ts
maryia-lapata Apr 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,3 @@ export {
EsQuerySortValue,
SortDirection,
} from '../../../../../plugins/data/public';
// @ts-ignore
export { buildPointSeriesData } from 'ui/agg_response/point_series/point_series';
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ import { IUiSettingsClient } from 'kibana/public';
import { EuiChartThemeType } from '@elastic/eui/dist/eui_charts_theme';
import { Subscription } from 'rxjs';
import { getServices } from '../../../kibana_services';
import { Chart as IChart } from '../helpers/point_series';

export interface DiscoverHistogramProps {
chartData: any;
chartData: IChart;
timefilterUpdateHandler: (ranges: { from: number; to: number }) => void;
}

Expand Down Expand Up @@ -163,7 +164,7 @@ export class DiscoverHistogram extends Component<DiscoverHistogramProps, Discove
};

public formatXValue = (val: string) => {
const xAxisFormat = this.props.chartData.xAxisFormat.params.pattern;
const xAxisFormat = this.props.chartData.xAxisFormat.params!.pattern;

return moment(val).format(xAxisFormat);
};
Expand Down Expand Up @@ -208,18 +209,19 @@ export class DiscoverHistogram extends Component<DiscoverHistogramProps, Discove
const { chartData } = this.props;
const { chartsTheme } = this.state;

if (!chartData || !chartData.series[0]) {
if (!chartData) {
return null;
}

const data = chartData.series[0].values;
const data = chartData.values;

/**
* Deprecation: [interval] on [date_histogram] is deprecated, use [fixed_interval] or [calendar_interval].
* see https://github.com/elastic/kibana/issues/27410
* TODO: Once the Discover query has been update, we should change the below to use the new field
*/
const { intervalESValue, intervalESUnit, interval: xInterval } = chartData.ordered;
const { intervalESValue, intervalESUnit, interval } = chartData.ordered;
const xInterval = interval.asMilliseconds();

const xValues = chartData.xAxisOrderedValues;
const lastXValue = xValues[xValues.length - 1];
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { uniq } from 'lodash';
import { Duration, Moment } from 'moment';
import { Unit } from '@elastic/datemath';

import { SerializedFieldFormat } from '../../../../../../../../plugins/expressions/common/types';

export interface Column {
id: string;
name: string;
}

export interface Row {
[key: string]: number | 'NaN';
}

export interface Table {
columns: Column[];
rows: Row[];
}

interface HistogramParams {
date: true;
interval: Duration;
intervalESValue: number;
intervalESUnit: Unit;
format: string;
bounds: {
min: Moment;
max: Moment;
};
}
export interface Dimension {
accessor: 0 | 1;
format: SerializedFieldFormat<{ pattern: string }>;
}

export interface Dimensions {
x: Dimension & { params: HistogramParams };
y: Dimension;
}

interface Ordered {
date: true;
interval: Duration;
intervalESUnit: string;
intervalESValue: number;
min: Moment;
max: Moment;
}
export interface Chart {
values: Array<{
x: number;
y: number;
}>;
xAxisOrderedValues: number[];
xAxisFormat: Dimension['format'];
xAxisLabel: Column['name'];
yAxisLabel?: Column['name'];
ordered: Ordered;
}

export const buildPointSeriesData = (table: Table, dimensions: Dimensions) => {
const { x, y } = dimensions;
const xAccessor = table.columns[x.accessor].id;
const yAccessor = table.columns[y.accessor].id;
const chart = {} as Chart;

chart.xAxisOrderedValues = uniq(table.rows.map(r => r[xAccessor] as number));
chart.xAxisFormat = x.format;
chart.xAxisLabel = table.columns[x.accessor].name;

const { intervalESUnit, intervalESValue, interval, bounds } = x.params;
chart.ordered = {
date: true,
interval,
intervalESUnit,
intervalESValue,
min: bounds.min,
max: bounds.max,
};

chart.yAxisLabel = table.columns[y.accessor].name;

chart.values = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits: I am not sure why you're explicitly passing rowIndex below? Also, what do you think about replacing the below lines with a bit more functional code?

 chart.values = table.rows
 	.filter(row => (row && row[yAccessor] !== 'NaN')
 	.map(row=>({
 		x: row[xAccessor] as number,
        y: row[yAccessor] as number,
 	}))
  });

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! thanks, I updated the PR.

table.rows.forEach((row, rowIndex) => {
if (row && row[yAccessor] !== 'NaN') {
chart.values.push({
x: row[xAccessor] as number,
y: row[yAccessor] as number,
});
}
});

if (!chart.values.length) {
chart.values.push({} as any);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can easily remove this lines, by a modification of histogram.tsx

const domainMin = data[0].x > domainStart ? domainStart : data[0].x;

e.g. by using

const domainMin = data[0]?.x > domainStart ? domainStart : data[0]?.x;

you no longer need to push this empty object, and the histogram is displaying 'No data to display'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done.


return chart;
};
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
* under the License.
*/

import { buildPointSeriesData, getServices } from '../../kibana_services';
import { getServices } from '../../kibana_services';
import { buildPointSeriesData } from './helpers';

function tableResponseHandler(table, dimensions) {
const converted = { tables: [] };
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/kibana.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ import './discover/legacy';
import './visualize/legacy';
import './management';
import './dev_tools';
import 'ui/agg_response';
import { showAppRedirectNotification } from '../../../../plugins/kibana_legacy/public';
import 'leaflet';
import { localApplicationService } from './local_application_service';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,3 @@

import { search } from '../../../../plugins/data/public';
export const { tabifyAggResponse, tabifyGetColumns } = search;

// @ts-ignore
export { buildHierarchicalData } from 'ui/agg_response/hierarchical/build_hierarchical_data';
// @ts-ignore
export { buildPointSeriesData } from 'ui/agg_response/point_series/point_series';

This file was deleted.

Loading