Navlink url tracker: Reset navlink on failed redirect #61460

flash1293 · 2020-03-26T13:53:27Z

I looked through the code and one scenario that leads to a redirect-loop is that when a missing saved object or is causing a redirect to management, it will still be tracked as the last active url.

Example:

Create visualization
Delete index pattern backing this visualization
Go to Visualize, click the visualization
This will (correctly) redirect you to management to fix the saved object
If you don't fix the saved object, but click on Visualize again right away, it will redirect you back to management - you can't access the Visualize listing page anymore before fixing this saved object

This PR solves this loop by resetting the navlink url to the default when a redirect to outside of the current app is happening - in the scenario from above the second click to Visualize will take you to the listing page instead.

I found 3 cases where this could happen:

Discover had a saved search open and the underlying index pattern is missing
Visualize had a visualization open and the underlying index pattern is missing
Visualize had a visualization open and the underlying saved search is missing

flash1293 · 2020-03-26T16:10:27Z

@elasticmachine merge upstream

mbondyra

tested on Chrome locally, works as expected. Code LGTM.

Dosant · 2020-03-27T09:55:28Z

Is this fixes original issue described in #59999 ?
Looks like this is fixes only this similar case @kertal pointed out #59999 (comment) ? If so, I guess we shouldn't completely close #59999

flash1293 · 2020-03-27T10:10:17Z

@Dosant I couldn't reproduce or find another issue that could cause the original description, I assumed it was a variant of that problem. Are you fine with closing this issue and open again when the problem pops up in another context?

cc @streamich did you run into this recently (since this issues got reported)?

Dosant

LGTM, tested using example flow in the description.

Don't know if this case is related and if this is also a regression in 7.7:

Go to visualize, save vis
Go to management / saved objects - delete that vis
Link in nabber still point to that deleted saved object. clicking it will just redirect me to listing page with a "missing" toast.

src/plugins/kibana_utils/public/history/redirect_when_missing.tsx

flash1293 · 2020-03-27T13:20:55Z

Don't know if this case is related and if this is also a regression in 7.7:

Go to visualize, save vis
Go to management / saved objects - delete that vis
Link in nabber still point to that deleted saved object. clicking it will just redirect me to listing page with a "missing" toast.

That's a good point, just tested with 7.4 and it behaves the same there. I'm not sure whether that qualifies as a bug though, it's at least consistent.

… fix-59999-redirect

kibanamachine · 2020-03-27T15:08:58Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: e9f4d17
Flaky suites:
- kibana-ciGroup6

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_field_visualize·ts.discover app discover field visualize button should preserve app filters in visualize

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:43]         └-: discover app
[00:01:43]           └-> "before all" hook
[00:01:43]           └-> "before all" hook
[00:09:15]           └-: discover field visualize button
[00:09:15]             └-> "before all" hook
[00:09:15]             └-> "before all" hook
[00:09:15]               │ debg load kibana index with default index pattern
[00:09:15]               │ info [discover] Loading "mappings.json"
[00:09:15]               │ info [discover] Loading "data.json.gz"
[00:09:15]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:15]               │ info [discover] Created index ".kibana"
[00:09:15]               │ debg [discover] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:09:15]               │ info [discover] Indexed 2 docs into ".kibana"
[00:09:15]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana/JsH-wDm7SAyeR2hYHqb2eg] update_mapping [_doc]
[00:09:15]               │ debg Migrating saved objects
[00:09:15]               │ proc [kibana]   log   [13:55:55.516] [info][savedobjects-service] Creating index .kibana_2.
[00:09:15]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:15]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:15]               │ proc [kibana]   log   [13:55:55.572] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:09:15]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:15]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] updating number_of_replicas to [0] for indices [.kibana_1]
[00:09:15]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] 8086 finished with response BulkByScrollResponse[took=37.7ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:09:15]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana/JsH-wDm7SAyeR2hYHqb2eg] deleting index
[00:09:15]               │ proc [kibana]   log   [13:55:55.912] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:09:15]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_2/ctfIebhXTZGzd2IckW4hUQ] update_mapping [_doc]
[00:09:15]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_2/ctfIebhXTZGzd2IckW4hUQ] update_mapping [_doc]
[00:09:15]               │ proc [kibana]   log   [13:55:55.978] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:09:15]               │ proc [kibana]   log   [13:55:56.034] [info][savedobjects-service] Finished in 520ms.
[00:09:15]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:09:16]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_2/ctfIebhXTZGzd2IckW4hUQ] update_mapping [_doc]
[00:09:17]               │ info [logstash_functional] Loading "mappings.json"
[00:09:17]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:17]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:17]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:17]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:18]               │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:09:18]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585315618515213592] [.kibana_2/ctfIebhXTZGzd2IckW4hUQ] update_mapping [_doc]
[00:09:19]             └-> should visualize a field in area chart
[00:09:19]               └-> "before each" hook: global before each
[00:09:19]               └-> "before each" hook
[00:09:19]                 │ debg go to discover
[00:09:19]                 │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:19]                 │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:19]                 │ debg ... sleep(700) start
[00:09:19]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585317359638#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:19]                 │
[00:09:19]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:20]                 │ debg ... sleep(700) end
[00:09:20]                 │ debg returned from get, calling refresh
[00:09:20]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585317359638#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:20]                 │
[00:09:20]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:21]                 │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:21]                 │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:21]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:21]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:24]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:24]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:24]                 │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-27T13:56:03Z
[00:09:24]                 │        Adding connection to http://localhost:6161/elasticsearch
[00:09:24]                 │
[00:09:24]                 │      "
[00:09:24]                 │ debg ... sleep(501) start
[00:09:25]                 │ debg ... sleep(501) end
[00:09:25]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover
[00:09:25]                 │ debg TestSubjects.exists(statusPageContainer)
[00:09:25]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:27]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:28]                 │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:09:28]                 │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:09:28]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:09:28]                 │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:09:28]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:09:28]                 │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:09:28]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:28]                 │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:09:28]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:09:28]                 │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:09:28]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:28]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:28]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:28]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:28]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:28]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:09:28]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:28]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:28]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:29]                 │ debg ... sleep(500) start
[00:09:29]                 │ debg ... sleep(500) end
[00:09:29]                 │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:09:29]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:29]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:29]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:30]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:30]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:30]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:30]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:30]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:30]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:30]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:30]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:09:30]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:30]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:30]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:30]                 │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:09:30]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:09:33]                 │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:09:33]                 │ debg TestSubjects.click(querySubmitButton)
[00:09:33]                 │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:33]                 │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:33]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:34]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:34]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:35]               │ debg TestSubjects.click(field-phpmemory)
[00:09:35]               │ debg Find.clickByCssSelector('[data-test-subj="field-phpmemory"]') with timeout=10000
[00:09:35]               │ debg Find.findByCssSelector('[data-test-subj="field-phpmemory"]') with timeout=10000
[00:09:36]               │ debg visualize a phpmemory field
[00:09:36]               │ debg TestSubjects.click(fieldVisualize-phpmemory)
[00:09:36]               │ debg Find.clickByCssSelector('[data-test-subj="fieldVisualize-phpmemory"]') with timeout=10000
[00:09:36]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-phpmemory"]') with timeout=10000
[00:09:37]               │ debg isGlobalLoadingIndicatorVisible
[00:09:37]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:37]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:39]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:09:39]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:39]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:39]               │ debg Inspector.open
[00:09:39]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:42]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:42]               │ debg TestSubjects.click(openInspectorButton)
[00:09:42]               │ debg Find.clickByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[00:09:42]               │ debg Find.findByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[00:09:42]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:42]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:42]               │ debg Inspector.expectTableData(0,10,58,320,2,171,080,2,3,240,1,3,520,1,3,880,1,4,120,1,4,640,1,4,760,1,5,680,1,7,160,1,7,400,1,8,400,1,8,800,1,8,960,1,9,400,1,10,280,1,10,840,1,13,080,1,13,360,1)
[00:09:42]               │ debg TestSubjects.find(inspectorPanel)
[00:09:42]               │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[00:09:43]               │ debg Close Inspector
[00:09:43]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:43]               │ debg Closing flyout inspectorPanel
[00:09:43]               │ debg TestSubjects.find(inspectorPanel)
[00:09:43]               │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[00:09:43]               │ debg Waiting up to 20000ms for flyout closed...
[00:09:43]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=1000
[00:09:44]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:44]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:44]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:47]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:47]               └- ✓ pass  (12.0s) "discover app discover field visualize button should visualize a field in area chart"
[00:09:47]             └-> should preserve app filters in visualize
[00:09:47]               └-> "before each" hook: global before each
[00:09:47]               └-> "before each" hook
[00:09:47]                 │ debg go to discover
[00:09:47]                 │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:47]                 │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:47]                 │ debg ... sleep(700) start
[00:09:47]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585317387958#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:47]                 │
[00:09:47]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:48]                 │ debg ... sleep(700) end
[00:09:48]                 │ debg returned from get, calling refresh
[00:09:48]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585317387958#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:48]                 │
[00:09:48]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:48]                 │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:48]                 │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:48]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:48]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:50]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:50]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:50]                 │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-27T13:56:30Z
[00:09:50]                 │        Adding connection to http://localhost:6161/elasticsearch
[00:09:50]                 │
[00:09:50]                 │      "
[00:09:51]                 │ debg ... sleep(501) start
[00:09:51]                 │ debg ... sleep(501) end
[00:09:51]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:51]                 │ debg --- retry.try error: URL changed, waiting for it to settle
[00:09:52]                 │ debg ... sleep(501) start
[00:09:52]                 │ debg ... sleep(501) end
[00:09:52]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:52]                 │ debg TestSubjects.exists(statusPageContainer)
[00:09:52]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:55]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:55]                 │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:09:55]                 │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:09:55]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:09:55]                 │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:09:55]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:09:55]                 │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:09:55]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:55]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:55]                 │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:09:55]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:09:55]                 │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:09:55]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:55]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:55]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:55]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:55]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:55]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:56]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:56]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:56]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:56]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:09:56]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:56]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:56]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:56]                 │ debg ... sleep(500) start
[00:09:57]                 │ debg ... sleep(500) end
[00:09:57]                 │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:09:57]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:57]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:57]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:57]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:57]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:57]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:57]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:09:57]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:57]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:58]                 │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:09:58]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:10:00]                 │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:10:01]                 │ debg TestSubjects.click(querySubmitButton)
[00:10:01]                 │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:10:01]                 │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:10:01]                 │ debg Find.waitForElementStale with timeout=10000
[00:10:01]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:10:01]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:10:03]               │ debg TestSubjects.click(addFilter)
[00:10:03]               │ debg Find.clickByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:10:03]               │ debg Find.findByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:10:03]               │ debg comboBox.set, comboBoxSelector: filterFieldSuggestionList
[00:10:03]               │ debg TestSubjects.find(filterFieldSuggestionList)
[00:10:03]               │ debg Find.findByCssSelector('[data-test-subj="filterFieldSuggestionList"]') with timeout=10000
[00:10:03]               │ debg comboBox.setElement, value: bytes
[00:10:03]               │ debg comboBox.isOptionSelected, value: bytes
[00:10:06]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:06]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:06]               │ debg Find.allByCssSelector('.euiFilterSelectItem[title^="bytes"]') with timeout=2500
[00:10:06]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:06]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:09]               │ debg --- retry.tryForTime error: [data-test-subj~="comboBoxOptionsList"] is not displayed
[00:10:09]               │ debg comboBox.set, comboBoxSelector: filterOperatorList
[00:10:09]               │ debg TestSubjects.find(filterOperatorList)
[00:10:09]               │ debg Find.findByCssSelector('[data-test-subj="filterOperatorList"]') with timeout=10000
[00:10:09]               │ debg comboBox.setElement, value: is between
[00:10:09]               │ debg comboBox.isOptionSelected, value: is between
[00:10:12]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:12]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:12]               │ debg Find.allByCssSelector('.euiFilterSelectItem[title^="is between"]') with timeout=2500
[00:10:12]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:12]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:15]               │ debg --- retry.tryForTime error: [data-test-subj~="comboBoxOptionsList"] is not displayed
[00:10:15]               │ debg TestSubjects.find(filterParams)
[00:10:15]               │ debg Find.findByCssSelector('[data-test-subj="filterParams"]') with timeout=10000
[00:10:26]               │ debg TestSubjects.click(saveFilter)
[00:10:26]               │ debg Find.clickByCssSelector('[data-test-subj="saveFilter"]') with timeout=10000
[00:10:26]               │ debg Find.findByCssSelector('[data-test-subj="saveFilter"]') with timeout=10000
[00:10:26]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:10:26]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:10:26]               │ debg TestSubjects.click(field-geo.src)
[00:10:26]               │ debg Find.clickByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:10:26]               │ debg Find.findByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:10:26]               │ debg visualize a geo.src field with filter applied
[00:10:26]               │ debg TestSubjects.click(fieldVisualize-geo.src)
[00:10:26]               │ debg Find.clickByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:26]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:37]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:37]               │      Wait timed out after 10122ms
[00:10:37]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:47]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:47]               │      Wait timed out after 10022ms
[00:10:48]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:58]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:58]               │      Wait timed out after 10037ms
[00:10:58]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:08]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:08]               │      Wait timed out after 10032ms
[00:11:09]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:19]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:19]               │      Wait timed out after 10055ms
[00:11:19]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:29]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:29]               │      Wait timed out after 10041ms
[00:11:30]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:40]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:40]               │      Wait timed out after 10052ms
[00:11:40]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:50]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:50]               │      Wait timed out after 10047ms
[00:11:51]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:01]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:01]               │      Wait timed out after 10028ms
[00:12:01]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:11]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:11]               │      Wait timed out after 10039ms
[00:12:12]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:22]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:22]               │      Wait timed out after 10031ms
[00:12:23]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:33]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:33]               │      Wait timed out after 10029ms
[00:12:33]               │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:33]               │      Wait timed out after 10029ms
[00:12:33]               │          at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
[00:12:33]               │          at process._tickCallback (internal/process/next_tick.js:68:7)
[00:12:34]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app discover field visualize button should preserve app filters in visualize.png"
[00:12:34]               │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,index:%27logstash-*%27,key:bytes,negate:!f,params:(gte:3500,lt:4000),type:range),range:(bytes:(gte:3500,lt:4000)))),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:12:34]               │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app discover field visualize button should preserve app filters in visualize.html
[00:12:34]               └- ✖ fail: "discover app discover field visualize button should preserve app filters in visualize"
[00:12:34]               │

Stack Trace

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
Wait timed out after 10029ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

History

💚 Build #36588 succeeded 360bc1a
💔 Build #36541 failed 2fafb4d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293 · 2020-03-27T15:11:44Z

@kertal See the flaky test above - do you think this is related to the recent changes in that area?

reset navlink on failed redirect

2fafb4d

flash1293 added v7.7.0 v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 26, 2020

Merge branch 'master' into fix-59999-redirect

360bc1a

flash1293 marked this pull request as ready for review March 27, 2020 08:39

flash1293 requested a review from a team March 27, 2020 08:39

flash1293 requested a review from a team as a code owner March 27, 2020 08:39

mbondyra approved these changes Mar 27, 2020

View reviewed changes

Dosant approved these changes Mar 27, 2020

View reviewed changes

src/plugins/kibana_utils/public/history/redirect_when_missing.tsx Outdated Show resolved Hide resolved

flash1293 added 3 commits March 27, 2020 14:21

Merge remote-tracking branch 'upstream/master' into fix-59999-redirect

d5f7195

rename new prop

7eecaf3

Merge branch 'fix-59999-redirect' of github.com:flash1293/kibana into…

e9f4d17

… fix-59999-redirect

flash1293 merged commit c0a14cd into elastic:master Mar 27, 2020

flash1293 deleted the fix-59999-redirect branch March 27, 2020 15:12

flash1293 mentioned this pull request Mar 27, 2020

[7.x] Navlink url tracker: Reset navlink on failed redirect (#61460) #61636

Merged

flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 27, 2020

Navlink url tracker: Reset navlink on failed redirect (elastic#61460)

9c8bdb5

flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 27, 2020

Navlink url tracker: Reset navlink on failed redirect (elastic#61460)

b2deed4

flash1293 mentioned this pull request Mar 27, 2020

[7.7] Navlink url tracker: Reset navlink on failed redirect (#61460) #61640

Merged

flash1293 added a commit that referenced this pull request Mar 27, 2020

Navlink url tracker: Reset navlink on failed redirect (#61460) (#61640)

0e909c2

flash1293 added a commit that referenced this pull request Mar 27, 2020

Navlink url tracker: Reset navlink on failed redirect (#61460) (#61636)

963b70a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navlink url tracker: Reset navlink on failed redirect #61460

Navlink url tracker: Reset navlink on failed redirect #61460

flash1293 commented Mar 26, 2020

flash1293 commented Mar 26, 2020

mbondyra left a comment

Dosant commented Mar 27, 2020 •

edited

Loading

flash1293 commented Mar 27, 2020

Dosant left a comment

flash1293 commented Mar 27, 2020

kibanamachine commented Mar 27, 2020

Standard Out

Stack Trace

flash1293 commented Mar 27, 2020

Navlink url tracker: Reset navlink on failed redirect #61460

Navlink url tracker: Reset navlink on failed redirect #61460

Conversation

flash1293 commented Mar 26, 2020

flash1293 commented Mar 26, 2020

mbondyra left a comment

Choose a reason for hiding this comment

Dosant commented Mar 27, 2020 • edited Loading

flash1293 commented Mar 27, 2020

Dosant left a comment

Choose a reason for hiding this comment

flash1293 commented Mar 27, 2020

kibanamachine commented Mar 27, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

flash1293 commented Mar 27, 2020

Dosant commented Mar 27, 2020 •

edited

Loading