Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote clusters] Fix flaky jest tests #58768

Merged
merged 25 commits into from
Apr 9, 2020
Merged

[Remote clusters] Fix flaky jest tests #58768

merged 25 commits into from
Apr 9, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Feb 27, 2020 •
edited
Loading

Fixes #57762
Fixes #57997
Fixes #57998

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor Author

retest

1 similar comment
@alisonelizabeth
Copy link
Contributor Author

retest

@alisonelizabeth
Copy link
Contributor Author

retest

3 similar comments
@alisonelizabeth
Copy link
Contributor Author

retest

@alisonelizabeth
Copy link
Contributor Author

retest

@alisonelizabeth
Copy link
Contributor Author

retest

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

retest

1 similar comment
@alisonelizabeth
Copy link
Contributor Author

retest

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

sebelga
sebelga approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few comments, none blockers.

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_edit.test.js Show resolved Hide resolved
x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_edit.test.js Outdated
await nextTick();
addRemoteClusterComponent.update();
await act(async () => {
await nextTick();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to also have a waitFor() here instead of the nextTick + component.update()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated this to use waitFor().

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_list.test.js
@@ -241,8 +242,10 @@ describe('<RemoteClusterList />', () => {
actions.clickBulkDeleteButton();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to the changes in this PR but I am surprised that it does not complain to update the state outside an act() call for those 2 actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave this as is for now, since it is unrelated to the current changes.

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

These tests have gone through CI successfully several times now, so I'm going to go ahead and merge. The latest failures were unrelated to the flakiness.

@alisonelizabeth alisonelizabeth merged commit 883af70 into elastic:master Apr 9, 2020
@alisonelizabeth alisonelizabeth deleted the remote_clusters/flaky_tests branch April 9, 2020 13:39
@alisonelizabeth alisonelizabeth mentioned this pull request Apr 9, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into es_ui_shared/…
bf57be0 
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana:
  [EPM] Update UI copy to use `integration` (elastic#63077)
  [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575)
  [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849)
  [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852)
  [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071)
  [APM] docs: add alerting examples for APM (elastic#62864)
  [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818)
  docs: fix rendering of bulleted list (elastic#62855)
  Exposed AddMessageVariables as separate component (elastic#63007)
  Add Data - Adding cloud reset password link to cloud instructions (elastic#62835)
  [ML] DF Analytics:  update memory estimate after adding exclude fields (elastic#62850)
  [Table Vis] Fix visualization overflow (elastic#62630)
  [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871)
  [Remote clusters] Fix flaky jest tests (elastic#58768)
  [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134)
  Move search source parsing and serializing to data (elastic#59919)
  [ML] Functional tests - stabilize typing in mml input (elastic#63091)
  [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123)
  [ML] Functional transform tests - stabilize source selection (elastic#63087)
  add embed flag to saved object url as well (elastic#62926)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
alisonelizabeth added a commit that referenced this pull request Apr 9, 2020
@alisonelizabeth
[7.x] [Remote clusters] Fix flaky jest tests (#58768) (#63116)
0cbf5e0
This was referenced Nov 2, 2020
Closed
Closed
@cjcenizal cjcenizal mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@alisonelizabeth @elasticmachine @cjcenizal @kibanamachine @sebelga