[SIEM][Case] Merge header components #57816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
requested review from
patrykkopycinski,
XavierM and
stephmilovic
and removed request for
patrykkopycinski and
XavierM
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
added
the
release_note:skip
|
@elasticmachine merge upstream |
cnasikas
force-pushed
the
merge_headers
branch
from
ea33994
to
41e0444
Compare
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 18, 2020
x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx
Outdated
Show resolved
Hide resolved
Closed
XavierM
reviewed
Feb 18, 2020
x-pack/legacy/plugins/siem/public/components/header_page/editable_title.test.tsx
Show resolved
Hide resolved
XavierM
reviewed
Feb 18, 2020
x-pack/legacy/plugins/siem/public/components/header_page/editable_title.test.tsx
Show resolved
Hide resolved
XavierM
reviewed
Feb 18, 2020
x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx
Outdated
Show resolved
Hide resolved
cnasikas
force-pushed
the
merge_headers
branch
from
09558b2
to
9bd3547
Compare
XavierM
approved these changes
Feb 19, 2020
stephmilovic
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Great work on this PR, especially unit tests @cnasikas! LGTM
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Feb 19, 2020
* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Feb 19, 2020
* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas
added a commit
that referenced
this pull request
Feb 19, 2020
* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 20, 2020
* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges the
header_page_newandheader_pagecomponent and creates a reusable editable title component. Many thanks to @patrykkopycinski for his amazing contribution and guidance.Checklist
Delete any items that are not applicable to this PR.
For maintainers