Url shortener #5497
Url shortener #5497
Conversation
BigFunger
force-pushed
the
url-shortener
branch
from
4568a92
to
5783f31
Compare
|
|
||
| export default function (server) { | ||
| async function updateMetadata(urlId, urlDoc) { | ||
| const client = server.plugins.elasticsearch.client; |
There was a problem hiding this comment.
Can these const client = server.plugins.elasticsearch.client; lines be moved to a single line within the top-level function?
|
@BigFunger keep in mind that we've standardized on snake_case filenames with #5383 |
|
If I create a link to a saved visualization, put that on an iframe somewhere, then delete the visualization, it throws up the "Create a new visualization" screen in the iframe.
Not sure if there's a good solution for this. Maybe you could add detail on the warning message for deleting a visualization if there are linked visualizations out there:
|
|
I don't think the problem regarding an iframe hosting a link to a deleted visualization is a huge deal. LGTM |
|
I just noticed that when we embed a Search in an iframe, there is a lot of tooling available because the Discover page hasn't really been updated for awareness that it's embedded:
|
| } | ||
| }); | ||
| } catch (err) { | ||
| console.log('Warning: Error updating url metadata', err); |
|
Functionally LGTM, made some small comments - passing back. |
|
Passing to @panda01 for seconds. Last commit changes LGTM |
|
LGTM! |
Fixes #1553
This is my first attempt at a working prototype for the url shortener, and I assume that it is going to require changes. I'm looking for input on the implementation.