Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home][Tutorial] Add data UI for IBM MQ Filebeat module #54238

Merged
merged 5 commits into from
Jan 13, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 8, 2020

Signed-off-by: ChrsMark chrismarkou92@gmail.com

Summary

This PR adds data UI for IBM MQ Filebeat module.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

part of: elastic/beats#15385
related to: https://github.com/elastic/observability-dev/issues/382

Screenshot 2020-01-08 at 13 22 59

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from a team January 8, 2020 11:01
@ChrsMark ChrsMark added v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 8, 2020
@ChrsMark ChrsMark changed the title Add data UI for IBM MQ Filebeat module [Home][Tutorial] Add data UI for IBM MQ Filebeat module Jan 10, 2020
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@timroes
Copy link
Contributor

timroes commented Jan 13, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ChrsMark
Copy link
Member Author

Thank you reviewing @timroes!

@ChrsMark ChrsMark merged commit fb9907e into elastic:master Jan 13, 2020
ChrsMark added a commit to ChrsMark/kibana that referenced this pull request Jan 13, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 13, 2020
…age-offset-floating-tooltip

* 'master' of github.com:elastic/kibana:
  [Maps] refactor isPointsOnly, isLinesOnly, and isPolygonsOnly to make synchronous (elastic#54067)
  Fix icon path in tutorial introduction (elastic#49684)
  [State Management] State containers improvements (elastic#54436)
  Fix floating tools rendering logic (elastic#54505)
  Handle another double quote special case (elastic#54474)
  [Home][Tutorial] Add data UI for IBM MQ Filebeat module (elastic#54238)
  fix(package): upgrade transitive dependency elliptic to v6.5.2 (elastic#54476)
  [Graph] Fix various a11y issues (elastic#54097)

# Conflicts:
#	src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jan 13, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants