[Canvas] Enable Embeddable maps #53971

crob611 · 2020-01-03T22:03:02Z

Summary

This enables Embeddable Maps for Canvas. The most important feature added here is interaction with a map (panning, zooming, adjusting time range, etc) will also update the expression backing the element so the map will return to that state on reload.

One feature this does not include is keeping track of which layers are enabled and disabled. There will need to be some changes to the Map Embeddable for that to happen and it will be tackled in a followup PR.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…teracted with

elasticmachine · 2020-01-03T22:04:00Z

Pinging @elastic/kibana-canvas (Team:Canvas)

lizozom · 2020-01-05T13:54:39Z

@elasticmachine merge upstream

crob611 · 2020-01-06T15:23:27Z

@elasticmachine merge upstream

timductive · 2020-01-07T17:24:32Z

This is looking really good in testing. The only issue I found is in the screenshot. If I have a global timefilter it seems like it is attempting to filter the data twice resulting in no data. Even when the panel time range and the global time range are the same.

crob611 · 2020-01-07T17:28:44Z

@timductive Is your TimeFilter set to use the order_date field, or is it using the default @timestamp?

timductive · 2020-01-07T17:29:47Z

@crob611 default @timestamp, let me try it with order_date

timductive · 2020-01-07T19:09:10Z

yep that bug was user error. It would be nice of the panel timerange could update when a global filter is applied. The data updates but not the panel timerange. Filters will be a little tricky until we revamp them as a whole though.

streamich

AppArch change LGTM.

streamich · 2020-01-08T12:32:30Z

x-pack/legacy/plugins/canvas/canvas_plugin_src/expression_types/embeddable.ts

@@ -5,11 +5,11 @@
 */

 import { ExpressionType } from 'src/plugins/expressions/public';
-import { EmbeddableInput } from 'src/legacy/core_plugins/embeddable_api/public/np_ready/public';
+import { EmbeddableInput } from '../../../../../../src/legacy/core_plugins/embeddable_api/public/np_ready/public';


Embeddables are in the New Platform, you can import everything from there.

Suggested change

import { EmbeddableInput } from '../../../../../../src/legacy/core_plugins/embeddable_api/public/np_ready/public';

import { EmbeddableInput } from '../../../../../../src/plugins/embeddable/public';

streamich · 2020-01-08T12:33:51Z

x-pack/legacy/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts

@@ -9,7 +9,7 @@ import { MAP_SAVED_OBJECT_TYPE } from '../../../maps/common/constants';
 import { VISUALIZE_EMBEDDABLE_TYPE } from '../../../../../../src/legacy/core_plugins/kibana/public/visualize_embeddable/constants';
 import { SEARCH_EMBEDDABLE_TYPE } from '../../../../../../src/legacy/core_plugins/kibana/public/discover/np_ready/embeddable/constants';

-export const EmbeddableTypes = {
+export const EmbeddableTypes: Record<string, string> = {


Maybe

Suggested change

export const EmbeddableTypes: Record<string, string> = {

export const EmbeddableTypes: Record<string, string | undefined> = {

or

Suggested change

export const EmbeddableTypes: Record<string, string> = {

export const EmbeddableTypes: { map: string, search: string, visualization: string } = {

timductive · 2020-01-08T14:08:28Z

Probably can close #44125 as part of this.

crob611 · 2020-01-10T18:38:08Z

@elasticmachine merge upstream

poffdeluxe

Looks good to me!

Tested it a decent bit and it seems to work well. My only thought is what to do if the saved map being rendered gets deleted. Current behavior is a blank element with an error being thrown in console. Could we just display the element in an error state or something?

poffdeluxe · 2020-01-10T22:35:00Z

x-pack/legacy/plugins/canvas/public/state/reducers/embeddable.ts

+      const { elementId, embeddableExpression } = payload;
+
+      // Find the element
+      const pageWithElement = workpadState.pages.find(page => {


nit: we're doin a lot of this kind of finding a page or element given an element id across this code. maybe something to refactor?

timductive · 2020-01-10T22:53:42Z

Testing looks good with the new changes!

crob611 · 2020-01-13T13:47:19Z

@elasticmachine merge upstream

kibanamachine · 2020-01-13T15:01:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a700ba0

History

💔 Build #19599 failed 7ed2f38
💔 Build #19393 failed 99922ca
💚 Build #19379 succeeded 4998db2
💚 Build #19144 succeeded e23a7ac
💚 Build #18094 succeeded 9308223

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Enables Embeddable maps in Canvas. Updates expressions as maps are interacted with * Fix type check errors * Update imports. Remove filters from initial embed expressions * Adds hide layer functionality to canvas map embeds * Fix typecheck error * Fix Type check Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...

* [Canvas] Enable Embeddable maps (#53971) * Enables Embeddable maps in Canvas. Updates expressions as maps are interacted with * Fix type check errors * Update imports. Remove filters from initial embed expressions * Adds hide layer functionality to canvas map embeds * Fix typecheck error * Fix Type check Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Re-enable embeds in Canvas Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Enables Embeddable maps in Canvas. Updates expressions as maps are interacted with * Fix type check errors * Update imports. Remove filters from initial embed expressions * Adds hide layer functionality to canvas map embeds * Fix typecheck error * Fix Type check Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Enables Embeddable maps in Canvas. Updates expressions as maps are in…

ab536d7

…teracted with

crob611 requested review from a team as code owners January 3, 2020 22:03

crob611 added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:enhancement review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.6.0 v8.0.0 labels Jan 3, 2020

elasticmachine and others added 2 commits January 5, 2020 05:54

Merge branch 'master' into embeddable-maps

c1afa2e

Fix type check errors

473876c

Merge branch 'master' into embeddable-maps

9308223

streamich self-requested a review January 7, 2020 17:28

streamich approved these changes Jan 8, 2020

View reviewed changes

timductive mentioned this pull request Jan 8, 2020

Vector Map #23123

Closed

Update imports. Remove filters from initial embed expressions

e23a7ac

elasticmachine and others added 2 commits January 10, 2020 12:38

Merge branch 'master' into embeddable-maps

4998db2

Adds hide layer functionality to canvas map embeds

99922ca

poffdeluxe approved these changes Jan 10, 2020

View reviewed changes

Corey Robertson added 2 commits January 12, 2020 15:30

Fix typecheck error

7ed2f38

Fix Type check

de7b39d

Merge branch 'master' into embeddable-maps

a700ba0

crob611 merged commit 24b3ecb into elastic:master Jan 13, 2020

crob611 mentioned this pull request Jan 13, 2020

[7.x] [Canvas] Enable Embeddable maps (#53971) #54649

Merged

This was referenced Jan 15, 2020

[Canvas] Support for maps and geospatial elements #27629

Closed

[Maps] Support to embed maps created from the Maps application into Canvas workpads #27711

Closed

[Canvas] Canvas embeddables blow up when time filter is deleted off a workpad. #44125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] Enable Embeddable maps #53971

[Canvas] Enable Embeddable maps #53971

crob611 commented Jan 3, 2020

elasticmachine commented Jan 3, 2020

lizozom commented Jan 5, 2020

crob611 commented Jan 6, 2020

timductive commented Jan 7, 2020

crob611 commented Jan 7, 2020

timductive commented Jan 7, 2020

timductive commented Jan 7, 2020

streamich left a comment

streamich Jan 8, 2020

streamich Jan 8, 2020

timductive commented Jan 8, 2020

crob611 commented Jan 10, 2020

poffdeluxe left a comment

poffdeluxe Jan 10, 2020

timductive commented Jan 10, 2020

crob611 commented Jan 13, 2020

kibanamachine commented Jan 13, 2020

	import { EmbeddableInput } from '../../../../../../src/legacy/core_plugins/embeddable_api/public/np_ready/public';
	import { EmbeddableInput } from '../../../../../../src/plugins/embeddable/public';

	export const EmbeddableTypes: Record<string, string> = {
	export const EmbeddableTypes: Record<string, string \| undefined> = {

	export const EmbeddableTypes: Record<string, string> = {
	export const EmbeddableTypes: { map: string, search: string, visualization: string } = {

[Canvas] Enable Embeddable maps #53971

[Canvas] Enable Embeddable maps #53971

Conversation

crob611 commented Jan 3, 2020

Summary

Checklist

For maintainers

elasticmachine commented Jan 3, 2020

lizozom commented Jan 5, 2020

crob611 commented Jan 6, 2020

timductive commented Jan 7, 2020

crob611 commented Jan 7, 2020

timductive commented Jan 7, 2020

timductive commented Jan 7, 2020

streamich left a comment

Choose a reason for hiding this comment

streamich Jan 8, 2020

Choose a reason for hiding this comment

streamich Jan 8, 2020

Choose a reason for hiding this comment

timductive commented Jan 8, 2020

crob611 commented Jan 10, 2020

poffdeluxe left a comment

Choose a reason for hiding this comment

poffdeluxe Jan 10, 2020

Choose a reason for hiding this comment

timductive commented Jan 10, 2020

crob611 commented Jan 13, 2020

kibanamachine commented Jan 13, 2020

💚 Build Succeeded

History