Add isSystemRequest support to Kibana Platform #53734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
force-pushed
the
np/system-api
branch
from
831ae85
to
c36f576
Compare
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
mshustov
reviewed
Dec 24, 2019
7 tasks
joshdover
force-pushed
the
np/system-api
branch
from
c36f576
to
2b1a6fc
Compare
💔 Build FailedTo update your PR or re-run it, just comment with: |
joshdover
force-pushed
the
np/system-api
branch
from
2b1a6fc
to
82f8de7
Compare
💔 Build FailedTo update your PR or re-run it, just comment with: |
joshdover
force-pushed
the
np/system-api
branch
from
82f8de7
to
29d03bf
Compare
💔 Build FailedTo update your PR or re-run it, just comment with: |
💔 Build FailedTo update your PR or re-run it, just comment with: |
joshdover
force-pushed
the
np/system-api
branch
from
e6b3f9c
to
9bb0b78
Compare
mshustov
reviewed
Dec 31, 2019
azasypkin
approved these changes
Jan 2, 2020
34 tasks
pgayvallet
reviewed
Jan 9, 2020
joshdover
force-pushed
the
np/system-api
branch
from
9bb0b78
to
b8f8522
Compare
joshdover
force-pushed
the
np/system-api
branch
from
8abf6e6
to
b465da8
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 24, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 28, 2020
joshdover
added a commit
that referenced
this pull request
Jan 28, 2020
This was referenced Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43970
Adds two new options:
core.http.fetchnow accepts anasSystemRequestoptionKibanaRequestnow has anisSystemRequestboolean propertyThis change also modifies how request interceptors work so that they now can only modify the
HttpFetchOptionsrather than the rawRequestobject. This enables Core to encapsulate its implementation details on how it converts HttpFetchOptions to a Request. It also reduces the API surface a bit by not needing to provide access to all of Request's methods.This change was helpful to support exposing to request interceptors whether or not a request was called with
asSystemRequest. This particular change could be split out as a separate PR if we think that is useful.In renaming this concept from "system api" to "system request", I also renamed the header that is used from
kbn-system-apitokbn-system-requestto better match the code. The backend will continue to supportkbn-system-apifor legacy plugin support and to support the use case where the client is running an older version than the server, where requests may still contain thekbn-system-apiheader.Opened #55203 to track removing support for the old header.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers