Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of addFiltersAndChangeTimeFilter #47450

Merged

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Oct 7, 2019

Summary

Part of #44377

To make the query services (filter, timefilter, query string) easier to use and also in order to move them to NP, we need to get rid of the indexPatterns dependencies in those services.

This PR gets rid of the addFiltersAndChangeTimeFilter method in filterManager.

Dev Docs

Deprecated addFiltersAndChangeTimeFilter.
If needed, replace with

    const { timeRangeFilter, restOfFilters } = extractTimeFilter(indexPattern.timeFieldName, filters);
    queryFilter.addFilters(restOfFilters);
    if (timeRangeFilter) changeTimeFilter(timefilter, timeRangeFilter);

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.5.0 Feature:NP Migration labels Oct 7, 2019
@lizozom lizozom self-assigned this Oct 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom requested a review from ppisljar October 7, 2019 11:48
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, waiting for green CI

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Oct 7, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 4ad46e5 into elastic:master Oct 7, 2019
@lizozom lizozom deleted the newplatform/filters/remove-index-patterns-1 branch November 14, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants