Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ui/persisted_logs - Part 1 #47225

Merged
merged 4 commits into from
Oct 3, 2019
Merged

Remove ui/persisted_logs - Part 1 #47225

merged 4 commits into from
Oct 3, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Oct 3, 2019 •
edited
Loading

Summary

  • Use npStart.core.chrome.recentlyAccessed directly (instead of importing ui/recentlyAccessed)
  • Delete PersistedLog factory

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested review from a team as code owners October 3, 2019 14:29
@lizozom lizozom self-assigned this Oct 3, 2019
@lizozom lizozom added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:AppArch labels Oct 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom changed the title Use npStart.core.chrome.recentlyAccessed and delete directive Remove ui/persisted_logs - Part 1 Oct 3, 2019
@lizozom lizozom mentioned this pull request Oct 3, 2019
Closed
26 tasks
@lizozom lizozom removed request for a team October 3, 2019 15:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

walterra
walterra approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

cqliu1
cqliu1 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes look good 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 3e91398 into elastic:master Oct 3, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Oct 3, 2019
Remove ui/persisted_logs - Part 1 (elastic#47225)
85c7dd9 
* Use npStart.core.chrome.recentlyAccessed and delete directive

* use recently accessed in ML

* re-update snapshots
@lizozom lizozom mentioned this pull request Oct 3, 2019
Merged
lizozom pushed a commit that referenced this pull request Oct 3, 2019
Remove ui/persisted_logs - Part 1 (#47225) (#47252)
60314da 
* Use npStart.core.chrome.recentlyAccessed and delete directive

* use recently accessed in ML

* re-update snapshots
@lizozom lizozom deleted the newplatform/data-plugin/persisted-log-1 branch November 14, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@joshdover joshdover joshdover approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @walterra @cqliu1 @joshdover