Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove index lifecycle phase filter from Index Management #45486

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Remove index lifecycle phase filter from Index Management #45486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions ...ns/index_lifecycle_management/__jest__/__snapshots__/extend_index_management.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions x-pack/legacy/plugins/index_lifecycle_management/public/extend_index_management/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,40 +160,6 @@ export const ilmFilterExtension = indices => {
},
],
},
{
type: 'field_value_selection',
field: 'ilm.phase',
name: i18n.translate('xpack.indexLifecycleMgmt.indexMgmtFilter.lifecyclePhaseLabel', {
defaultMessage: 'Lifecycle phase',
}),
multiSelect: 'or',
options: [
{
value: 'hot',
view: i18n.translate('xpack.indexLifecycleMgmt.indexMgmtFilter.hotLabel', {
defaultMessage: 'Hot',
}),
},
{
value: 'warm',
view: i18n.translate('xpack.indexLifecycleMgmt.indexMgmtFilter.warmLabel', {
defaultMessage: 'Warm',
}),
},
{
value: 'cold',
view: i18n.translate('xpack.indexLifecycleMgmt.indexMgmtFilter.coldLabel', {
defaultMessage: 'Cold',
}),
},
{
value: 'delete',
view: i18n.translate('xpack.indexLifecycleMgmt.indexMgmtFilter.deleteLabel', {
defaultMessage: 'Delete',
}),
},
],
},
];
}
};
Expand Down
7 changes: 1 addition & 6 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4887,14 +4887,9 @@
"xpack.indexLifecycleMgmt.indexManagementTable.removeLifecyclePolicyConfirmModal.removePolicyToIndexError": "ポリシーの削除中にエラーが発生しました",
"xpack.indexLifecycleMgmt.indexMgmtBanner.errorMessage": "{ numIndicesWithLifecycleErrors, number}\n {numIndicesWithLifecycleErrors, plural, one {インデックスに} other {インデックスに} }\n インデックスライフサイクルエラー",
"xpack.indexLifecycleMgmt.indexMgmtBanner.filterLabel": "エラーを表示",
"xpack.indexLifecycleMgmt.indexMgmtFilter.coldLabel": "コールド",
"xpack.indexLifecycleMgmt.indexMgmtFilter.deleteLabel": "削除",
"xpack.indexLifecycleMgmt.indexMgmtFilter.hotLabel": "ホット",
"xpack.indexLifecycleMgmt.indexMgmtFilter.lifecyclePhaseLabel": "ライフサイクルのフェーズ",
"xpack.indexLifecycleMgmt.indexMgmtFilter.lifecycleStatusLabel": "ライフサイクルステータス",
"xpack.indexLifecycleMgmt.indexMgmtFilter.managedLabel": "管理中",
"xpack.indexLifecycleMgmt.indexMgmtFilter.unmanagedLabel": "管理対象外",
"xpack.indexLifecycleMgmt.indexMgmtFilter.warmLabel": "ウォーム",
"xpack.indexLifecycleMgmt.indexPriorityLabel": "インデックスの優先順位",
"xpack.indexLifecycleMgmt.learnMore": "その他のリソース",
"xpack.indexLifecycleMgmt.nodeAttrDetails.hostField": "ホスト",
Expand Down Expand Up @@ -10368,4 +10363,4 @@
"xpack.watcher.watchActions.logging.logTextIsRequiredValidationMessage": "ログテキストが必要です。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add back newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a result of running node scripts/i18n_check --fix so I'm inclined to leave it in. Seems like something we should change in the tool itself.

7 changes: 1 addition & 6 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5031,14 +5031,9 @@
"xpack.indexLifecycleMgmt.indexManagementTable.removeLifecyclePolicyConfirmModal.removePolicyToIndexError": "删除策略时出错",
"xpack.indexLifecycleMgmt.indexMgmtBanner.errorMessage": "{ numIndicesWithLifecycleErrors, number}\n {numIndicesWithLifecycleErrors, plural, one { 个索引已} other { 个索引已} }\n 生命周期错误",
"xpack.indexLifecycleMgmt.indexMgmtBanner.filterLabel": "显示错误",
"xpack.indexLifecycleMgmt.indexMgmtFilter.coldLabel": "冷",
"xpack.indexLifecycleMgmt.indexMgmtFilter.deleteLabel": "删除",
"xpack.indexLifecycleMgmt.indexMgmtFilter.hotLabel": "热",
"xpack.indexLifecycleMgmt.indexMgmtFilter.lifecyclePhaseLabel": "生命周期阶段",
"xpack.indexLifecycleMgmt.indexMgmtFilter.lifecycleStatusLabel": "生命周期状态",
"xpack.indexLifecycleMgmt.indexMgmtFilter.managedLabel": "受管",
"xpack.indexLifecycleMgmt.indexMgmtFilter.unmanagedLabel": "未受管",
"xpack.indexLifecycleMgmt.indexMgmtFilter.warmLabel": "温",
"xpack.indexLifecycleMgmt.indexPriorityLabel": "索引优先级",
"xpack.indexLifecycleMgmt.learnMore": "了解详情",
"xpack.indexLifecycleMgmt.nodeAttrDetails.hostField": "主机",
Expand Down Expand Up @@ -10511,4 +10506,4 @@
"xpack.watcher.watchActions.logging.logTextIsRequiredValidationMessage": "“日志文本”必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}