Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): fix babel plugin discover for thread-loader-warmup #44106

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 27, 2019

That change fixes the thread-loader warmup discoverability for babel declared plugins that was failing under certain environments.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 v7.4.0 labels Aug 27, 2019
@mistic mistic requested review from mgreau and spalger August 27, 2019 15:19
@mistic mistic self-assigned this Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@mistic mistic added the release_note:skip Skip the PR/issue when compiling release notes label Aug 27, 2019
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit.

packages/kbn-babel-preset/webpack_preset.js Outdated Show resolved Hide resolved
Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mistic
Copy link
Member Author

mistic commented Aug 27, 2019

7.x: fdc3458

mistic added a commit to mistic/kibana that referenced this pull request Aug 27, 2019
…c#44106)

* chore(NA): fix babel plugin discover for thread-loader-warmup

* chore(NA): apply changes accordingly the PR review
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Aug 27, 2019
…c#44106)

* chore(NA): fix babel plugin discover for thread-loader-warmup

* chore(NA): apply changes accordingly the PR review
mistic added a commit that referenced this pull request Aug 27, 2019
#44124)

* chore(NA): fix babel plugin discover for thread-loader-warmup

* chore(NA): apply changes accordingly the PR review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants