Add base path to rollup index pattern endpoint's request to internal endpoint #39745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex pattern endpoint
jen-huang
added
bug
|
Pinging @elastic/es-ui |
jen-huang
added
the
release_note:skip
💚 Build Succeeded |
wylieconlon
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #39047 affected this handler for the
/api/index_patterns/rollup/_fields_for_wildcardroute. This handler calls another internal route,/api/index_patterns/_fields_for_wildcardusingserver.inject. After the changes in that PR, the base path needs to be added to the internal route request URL.In the UI, the effect of this breakage is that when creating a rollup index pattern, the type of fields in the rollup index cannot be identified, including the all-important date histogram field. Screenshot showing list of fields with undefined types:
This PR adds the base path so that types are correctly identified again.