Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds anomaly time to aria label for anomalies table actions button #32777

Merged
merged 2 commits into from
Mar 11, 2019
Merged

[ML] Adds anomaly time to aria label for anomalies table actions button #32777

merged 2 commits into from
Mar 11, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Mar 8, 2019 •
edited
Loading

Summary

Adds the time of the anomaly to the aria-label of the actions button in each row of the anomalies table to provide extra context of the row the action is on. Screen reader now announces e.g. Select action for anomaly at November 11th 2018, 22:30:00

Checklist

For maintainers

Fixes #31103

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson requested a review from a team as a code owner March 8, 2019 15:57
walterra
walterra approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@peteharverson
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 1ebe64f into elastic:master Mar 11, 2019
@peteharverson peteharverson deleted the ml-table-actions-aria-label branch March 11, 2019 09:44
@peteharverson peteharverson mentioned this pull request Mar 11, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 11, 2019
@peteharverson
[ML] Adds anomaly time to aria label for anomalies table actions butt…
5d13065 
…on (elastic#32777)

* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
@peteharverson peteharverson mentioned this pull request Mar 11, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Mar 11, 2019
@peteharverson
[ML] Adds anomaly time to aria label for anomalies table actions butt…
25ae00c 
…on (elastic#32777)

* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
peteharverson added a commit that referenced this pull request Mar 11, 2019
@peteharverson
[ML] Adds anomaly time to aria label for anomalies table actions butt…
738886f 
…on (#32777) (#32878)

* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
peteharverson added a commit that referenced this pull request Mar 11, 2019
@peteharverson
[ML] Adds anomaly time to aria label for anomalies table actions butt…
d3d76ce 
…on (#32777) (#32877)

* [ML] Adds anomaly time to aria label for anomalies table actions button

* [ML] Update CHinese translation for edited table actions button
alvarezmelissa87
alvarezmelissa87 reviewed Mar 12, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late but LGTM ⚡️

@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
@aphelionz aphelionz mentioned this pull request Jul 3, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 left review comments

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml Project:Accessibility release_note:enhancement review v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Accessibility) Machine Learning "Select Action" button in Single Metric View lacking label
6 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic @sophiec20