Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Adding size column and estimated size to serverless #193998

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Sep 25, 2024

Closes https://github.com/elastic/logs-dev/issues/179.

This PR aims to enable:
The estimated size is displayed in Serverless in the following areas:

  • Estimated and size column in main page
  • Size in Overview section of Dataset details

Demo

Screen.Recording.2024-09-25.at.15.12.41.mov

@yngrdyn yngrdyn requested a review from a team as a code owner September 25, 2024 13:16
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 25, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 25, 2024
@mohamedhamed-ahmed
Copy link
Contributor

I remember there were a couple of checks on the UI as well, do we need to clean them up ?
IIRC in the statemachine and the columns file, probably in the flyout as well

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 25, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / Serverless observability API Dataset Quality gets the data stream details returns "sizeBytes" correctly
  • [job] [logs] FTR Configs #20 / Serverless observability API Dataset Quality gets the data stream details returns "sizeBytes" correctly
  • [job] [logs] FTR Configs #25 / serverless observability UI Dataset Quality Flyout overview summary panel should show summary KPIs
  • [job] [logs] FTR Configs #25 / serverless observability UI Dataset Quality Flyout overview summary panel should show summary KPIs
  • [job] [logs] Jest Integration Tests #1 / when rolling back to an older version kibana should detect that a later version alias exists, and abort

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants