[Security Solution][Notes] - add button to add note from flyout note header block #193903
+170
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
…header block (elastic#193903) (cherry picked from commit faeca17)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
… note header block (#193903) (#194033) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - add button to add note from flyout note header block (#193903)](#193903) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T15:29:33Z","message":"[Security Solution][Notes] - add button to add note from flyout note header block (#193903)","sha":"faeca17d2bc28720a812cbcf357a7f947b6225b7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - add button to add note from flyout note header block","number":193903,"url":"#193903 Solution][Notes] - add button to add note from flyout note header block (#193903)","sha":"faeca17d2bc28720a812cbcf357a7f947b6225b7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#193903 Solution][Notes] - add button to add note from flyout note header block (#193903)","sha":"faeca17d2bc28720a812cbcf357a7f947b6225b7"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes an addition to the work done in this previous PR that was adding a new block to the header of the alert details flyout. Since that PR was merged, the mocks changed a but and we now have to add a button to allow users to add new notes.
Here are the 2 states from the mocks:
The PR adds the Add note
EuiButtonwhen no notes are present, as well as theEuiButtonIconwhen some notes have already been added to the document.Screen.Recording.2024-09-24.at.11.52.39.AM.mov
The PR also makes a small change to the translations keys as I was starting to have conflict with the translations for notes in Timeline.
Checklist
#193342