Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [dashboard] Migrate Dashboard internal components to DashboardApi (#193220) #193739

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[8.x] [dashboard] Migrate Dashboard internal components to DashboardApi (#193220) #193739

merged 1 commit into from
Sep 23, 2024
+299 −181

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[dashboard] Migrate Dashboard internal components to DashboardApi (el…
8b0fc4c 
…astic#193220)

PR replaces `useDashboardContainer` with `useDashboardApi`.
`useDashboardApi` returns `DashboardApi` instead of
`DashboardContainer`.

After this PR, all react context's in dashboard return `DashboardApi`
and thus all components are now prepared for the migration from
DashboardContainer to DashboardApi.

---------

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 92da176)
@kibanamachine kibanamachine enabled auto-merge (squash) September 23, 2024 15:26
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / Use get case configuration hook returns the initial configuration if none matches the owner

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 481.7KB 490.7KB +9.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dashboard 13 15 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 26.9KB 26.9KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nreese

@kibanamachine kibanamachine merged commit ce14b1f into elastic:8.x Sep 23, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees

@nreese nreese

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @nreese