[Automatic Import] Add Error handling framework #193577
Merged
+332
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
added
enhancement
bhapas
force-pushed
the
automatic_import_improve_error_logging
branch
from
2a6bed6
to
6486b9c
Compare
bhapas
commented
Sep 24, 2024
| export const RECURSION_LIMIT_ERROR = i18n.translate( | ||
| 'xpack.plugins.integration_assistant.server.errors.recursionLimitReached', | ||
| { | ||
| defaultMessage: 'Max attempts exceeded. Please try again.', |
There was a problem hiding this comment.
@jamiehynds Need a better wording here.
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
bhapas
force-pushed
the
automatic_import_improve_error_logging
branch
from
6486b9c
to
73106e0
Compare
bhapas
force-pushed
the
automatic_import_improve_error_logging
branch
from
81d7d9a
to
a568412
Compare
semd
reviewed
Sep 25, 2024
semd
reviewed
Sep 25, 2024
.../create_integration/create_integration_assistant/steps/data_stream_step/generation_modal.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Sep 25, 2024
...nents/create_integration/create_integration_assistant/steps/data_stream_step/translations.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Sep 25, 2024
x-pack/plugins/integration_assistant/server/routes/routes_util.ts
Outdated
Show resolved
Hide resolved
bhapas
added
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @bhapas |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
## Release Note Adds error handling framework that provides error message with more context to user. ## Summary Relates - [192916](elastic#192916) This PR adds an error handling framework. - Add Error classes for specific error scenarios. - If the error caught is of the predefined Error type the `message` and `errorCode` is sent back to UI from server. - The original error message is used to track telemetry and the errorCode can be translated into a User visible error. - If there is any non-predefined error server still throws a `badRequest` with the error message. This PR also adds/updates the graph images for different langgraphs ## Screenshots for error messages <img width="690" alt="image" src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea"> <img width="691" alt="image" src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 9fb6f55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
Adds error handling framework that provides error message with more context to user.
Summary
Relates - 192916
This PR adds an error handling framework.
messageanderrorCodeis sent back to UI from server.badRequestwith the error message.This PR also adds/updates the graph images for different langgraphs
Screenshots for error messages
Checklist
For maintainers