-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness #193490
Open
paul-tavares
wants to merge
30
commits into
elastic:main
Choose a base branch
from
paul-tavares:task/olm-8538-endpoint-list-details-space-aware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+726
−785
Open
[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness #193490
Changes from 27 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2ae90ab
update fleet services factory to initialize certain clients lazyly
paul-tavares 9c2b48e
New saved objects factory service
paul-tavares d4c5bcd
Enhance Endpoint app context service to provide access to new SO clie…
paul-tavares f592bd2
Merge remote-tracking branch 'upstream/main' into task/olm-8538-endpo…
paul-tavares 6e3792b
Add TODO reminders to delete old SO modules
paul-tavares 29cf484
Refactor EndpointMetadataService construction arguments
paul-tavares 2e82049
Refactor EndpointFleetServicesFactory constructor arguments to use ne…
paul-tavares e898fab
Refactor EndpointAppContextServices `.start()` contract
paul-tavares 4888a03
Merge remote-tracking branch 'upstream/main' into task/olm-8538-endpo…
paul-tavares 360e1ad
Update Fleet server mocks and add new one for FleetStartContract (plu…
paul-tavares 11124e4
Update mocks for Endpoint App Context services
paul-tavares fe2644a
Refactor EndpointFleetServicesFactory and remove SO client property a…
paul-tavares d36cf23
Delete internal so client utilities (old)
paul-tavares a133744
Refactor Metadata service - move all dependencies to constructor and …
paul-tavares 75ba84f
Improve mocks
paul-tavares 096ef90
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine e75e531
Merge remote-tracking branch 'upstream/main' into task/olm-8538-endpo…
paul-tavares f4a064a
Merge branch 'main' into task/olm-8538-endpoint-list-details-space-aware
paul-tavares 3df719e
Merge remote-tracking branch 'origin/task/olm-8538-endpoint-list-deta…
paul-tavares f7c796b
Fix fleet mock
paul-tavares 96f9149
Fix several tests and mocks
paul-tavares a5a3b60
Move fixes to tests and mocks due to refactor
paul-tavares e396381
Merge remote-tracking branch 'upstream/main' into task/olm-8538-endpo…
paul-tavares afc21ef
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 2a55e44
Fix types in `cloud_defend`, `cloud_security_posture` and `observabil…
paul-tavares 4f2f64f
Fix additional mocks in tests files
paul-tavares 3e443f9
Merge remote-tracking branch 'origin/task/olm-8538-endpoint-list-deta…
paul-tavares 3e418a8
adjust Cloud Defend and Cloud posture plugins use of fleet start cont…
paul-tavares a9bab9f
Merge remote-tracking branch 'upstream/main' into task/olm-8538-endpo…
paul-tavares 7231903
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,15 +62,13 @@ const createMockFleetStartContract = (): DeeplyMockedKeys<FleetStartContract> => | |
fromRequest: jest.fn(async (_) => createFleetAuthzMock()), | ||
}, | ||
fleetSetupCompleted: jest.fn().mockResolvedValue(undefined), | ||
// @ts-expect-error 2322 | ||
agentService: createMockAgentService(), | ||
// @ts-expect-error 2322 | ||
packageService: createMockPackageService(), | ||
agentPolicyService: createMockAgentPolicyService(), | ||
registerExternalCallback: jest.fn((..._: ExternalCallback) => {}), | ||
packagePolicyService: createPackagePolicyServiceMock(), | ||
createArtifactsClient: jest.fn().mockReturnValue(createArtifactsClientMock()), | ||
}; | ||
} as unknown as DeeplyMockedKeys<FleetStartContract>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question about importing the mock from the fleet |
||
}; | ||
|
||
describe('Cloud Security Posture Plugin', () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we replace this
createMockFleetStartContract
with the newly createdcreateFleetStartContractMock
imported fromfleet/server/mocks
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @opauloh . Just pushed the changes you suggested.