-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kbn-flot-charts codeowners #193351
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-presentation LGTM
"owner": [ | ||
"@elastic/kibana-presentation", | ||
"@elastic/kibana-visualizations", | ||
"@elastic/stack-monitoring", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"owner": [ | |
"@elastic/kibana-presentation", | |
"@elastic/kibana-visualizations", | |
"@elastic/stack-monitoring", | |
] | |
"owner": [ | |
"@elastic/kibana-presentation", | |
"@elastic/stack-monitoring", | |
] |
The visualization team doesn't use this package any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed d68793b
.github/CODEOWNERS
Outdated
@@ -467,7 +467,7 @@ src/plugins/files_management @elastic/appex-sharedux | |||
src/plugins/files @elastic/appex-sharedux | |||
packages/kbn-find-used-node-modules @elastic/kibana-operations | |||
x-pack/plugins/fleet @elastic/fleet | |||
packages/kbn-flot-charts @elastic/kibana-operations | |||
packages/kbn-flot-charts @elastic/kibana-presentation @elastic/kibana-visualizations @elastic/stack-monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/kbn-flot-charts @elastic/kibana-presentation @elastic/kibana-visualizations @elastic/stack-monitoring | |
packages/kbn-flot-charts @elastic/kibana-presentation @elastic/stack-monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed d68793b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGT stack monitoring
💛 Build succeeded, but was flaky
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
As best I can tell this was default assigned to operations during a large refactor - #138965.
Operations is mostly disconnected from the UI. I'm proposing transferring this over to area teams where flot is in use - stack monitoring, canvas, and timelion.