Updated js-yaml to v4 #190678
Merged
Updated js-yaml to v4 #190678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
4 similar comments
|
/ci |
|
/ci |
|
/ci |
|
/ci |
elena-shostak
force-pushed
the
190624-js-yaml-upgrade
branch
from
cc25199
to
c6c985a
Compare
|
/ci |
1 similar comment
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
1 similar comment
|
/ci |
elena-shostak
commented
Aug 21, 2024
yarn.lock
Outdated
| @@ -21676,7 +21676,7 @@ js-yaml@4.1.0, js-yaml@^4.1.0: | |||
| dependencies: | |||
| argparse "^2.0.1" | |||
|
|
|||
| js-yaml@^3.13.1, js-yaml@^3.14.1: | |||
| js-yaml@^3.13.1: | |||
There was a problem hiding this comment.
This is coming from @istanbuljs/load-nyc-config, we can also set a resolution, though seems negligible for now.
"**/@istanbuljs/load-nyc-config/**/js-yaml": "4.1.0"
There was a problem hiding this comment.
I agree. As this is a transitive development dependency, I think it is ok to leave this for now.
elena-shostak
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
elena-shostak
force-pushed
the
190624-js-yaml-upgrade
branch
from
3cab99a
to
46dc19c
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Sep 18, 2024
kibanamachine
added
v9.0.0
backport:skip
delanni
added a commit
that referenced
this pull request
Sep 19, 2024
## Summary Main seems to be broken because of a check. These are probably regenerated with a different shape since the js-yaml update: #190678
delanni
added a commit
that referenced
this pull request
Sep 19, 2024
elena-shostak
added a commit
that referenced
this pull request
Sep 20, 2024
## Summary Since js-yaml update has been merged in #190678 we don't need `no_unsafe_js_yaml ` anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated
js-yamlto4.1.0.This PR also introduces a type override for the
js-yamlload function to maintain compatibility across the codebase. Specifically, updated type definition of the load function looks as follows:The original type definition of the load function in
js-yamlchanged fromanytounknown. This change would require extensive type updates throughout the entire repository to accommodate theunknowntype. To avoid widespread type changes and potential issues in the codebase, the type is overriden back toanyfor now.This is a temporary measure, we plan to address the necessary type changes in subsequent PRs, where teams will gradually update the codebase to work with the
unknowntype.Checklist
Release note
Updated
js-yamlto4.1.0.