Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update sonarqube scan paths to include packages #189937

Merged
merged 2 commits into from
Aug 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sonar-project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ sonar.host.url=https://sonar.elastic.dev

sonar.sources=\
packages, \
plugins, \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removed, because this folder only ever contains anything for external plugin devs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , it's empty - didn't see a need for it.

src, \
x-pack/packages, \
x-pack/plugins
Expand All @@ -13,6 +12,8 @@ sonar.exclusions=\
**/*.mocks.*, \
**/*.spec.*, \
**/*.stories.js, \
**/*.md, \
**/*.mdx, \
**/*.stories.ts, \
**/*.story.js, \
**/*.story.ts, \
Expand All @@ -37,7 +38,6 @@ sonar.exclusions=\
**/mock_responses/**/*, \
**/mocks/**/*, \
**/node_modules/**/*, \
**/packages/**/*, \
**/public/**/*, \
**/scripts/**/*, \
**/storybook/**/*, \
Expand Down