[Embeddable Rebuild] [Controls] Fix control state on edit

[Heenawter]

Summary

This PR fixes control editing so that, when the control type is changed, extra state from the old type gets removed. Prior to this, controls were keeping unrelated state - for example, switching from a range slider to a search control would result in a search control with the "step" property.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[Heenawter]

/ci

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[nreese]

I don't think this issue is a bug or that that this issue needs to be resolved. The serializeState methods for the control types do not propagate keys from other control types. I think its ok for runtime state to maybe contain keys from other control types. A control type's buildControl method will just ignore unknown keys. Then on serialize, only state for the control type is persisted and clean-up is done in a single location. This has the added benefit of keeping all state around for the entire user session, so that users can change control types freely and never loose information.

[Heenawter]

@nreese Hmm... I am personally not a huge fan of having dirty state sticking around. This feels like a bigger risk of bugs to me than the current picking I am doing... For example, what if we have two control types that have some state that shares a name? It's also a change in behaviour from the way controls used to work - should they really remember state like this? But I understand that this is up for debate, so I guess I'm fine removing this.

I will have to keep the change in examples/controls_example/public/react_controls/data_controls/initialize_data_control.tsx (this was a legit bug because we are just sending in the initial control state with a new type, which causes an error to be thrown when switching from a search control to a range slider for example because the field renames a string type).

[Heenawter]

@nreese I removed the state cleaning in bb5cfb6 👍

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: e5568db

Failed CI Steps

• Jest Integration Tests #3

Metrics [docs]

✅ unchanged

History

• 💔 Build #223098 failed de45351
• 💚 Build #223045 succeeded ce2897f
• 💚 Build #222946 succeeded 4d9b5c1
• 💛 Build #222742 was flaky fbc3620
• 💚 Build #222728 succeeded 546efc3
• 💔 Build #222721 failed d835d0a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

[nreese]

LGTM
code review, tested in chrome