-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Updated eem schema #188763
[APM] Updated eem schema #188763
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -72,7 +72,10 @@ export async function getEntities({ | |||
|
|||
return entities.map((entity): ServiceEntities => { | |||
return { | |||
serviceName: entity.entity.identityFields.service.name, | |||
serviceName: entity.service.name, | |||
environment: Array.isArray(entity.service?.environment) // TODO fix this in the EEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do we need to support multiple environments? And how do we want to fix it - have a single environment or have an array (I see currently we get the first one in case of an array)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support services with multiple environments already. In service inventory we group them. This seems to be introduces by the recent changes in EEM. Which needs to be fixed in their schema.
If the environment exists they return a string. If the environment is empty they return an empty array. This needs to be consistent. I need to create an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚 Build Succeeded
Metrics [docs]Async chunks
History |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
closes: #188761
changes
logRatePerMinute
tologRate
(EEM change)