Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Updated eem schema #188763

Merged
merged 4 commits into from
Jul 22, 2024
Merged

[APM] Updated eem schema #188763

merged 4 commits into from
Jul 22, 2024

Conversation

kpatticha
Copy link
Contributor

Summary

closes: #188761

changes

  • identityFields returns only the fields, query directly service name and service environment from entity document (EEM change)
  • Rename logRatePerMinute to logRate (EEM change)

@kpatticha kpatticha requested a review from a team as a code owner July 19, 2024 15:19
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha added backport:skip This commit does not require backporting v8.16.0 labels Jul 19, 2024
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -72,7 +72,10 @@ export async function getEntities({

return entities.map((entity): ServiceEntities => {
return {
serviceName: entity.entity.identityFields.service.name,
serviceName: entity.service.name,
environment: Array.isArray(entity.service?.environment) // TODO fix this in the EEM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Do we need to support multiple environments? And how do we want to fix it - have a single environment or have an array (I see currently we get the first one in case of an array)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support services with multiple environments already. In service inventory we group them. This seems to be introduces by the recent changes in EEM. Which needs to be fixed in their schema.

If the environment exists they return a string. If the environment is empty they return an empty array. This needs to be consistent. I need to create an issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 19, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -81.0B

History

@kpatticha kpatticha added the release_note:skip Skip the PR/issue when compiling release notes label Jul 22, 2024
@kpatticha kpatticha enabled auto-merge (squash) July 22, 2024 07:55
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 22, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -81.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 7089f35 into elastic:main Jul 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Replace any reference to identityFields
6 participants