Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integrations AutoImport] Rebranding "Integration Assistant" to "Integration Automatic Import" #188750

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

semd
Copy link
Contributor

@semd semd commented Jul 19, 2024

Summary

Renaming the code to be consistent with the rebranding of "Integration Assistant" to "Integration Auto Import":

The former integration_assistant plugin has been renamed to integration_import, which exposes different components:

integration_import_card_button: The button displayed at the top right corner of the Integrations page.

integration_import: The top-level page that renders at the /integrations/import* path, former /integration/create*.

  • integration_import_landing: renders at /integrations/import path, former /integration/create. The landing page of the plugin application.
  • integration_import_upload: renders at /integrations/import/upload path, former /integration/create/upload. The Zip package upload page.
  • integration_auto_import: renders at /integrations/import/automatic path, former /integration/create/assistant. This is the actual Automatic Import functionality.

All the component names, variables, plugin references, translation keys... have been refactored to reflect the change.

Exception

The plugin config key has not been changed to prevent current deployments using xpack.integration_assistant.enabled: true from crashing.

To change the config key we would need a config migration. However, since the plan is to enable the plugin by default for 8.16, we can wait until that moment to change the config key and clean all references to xpack.integration_assistant.

@semd semd added refactoring release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 labels Jul 19, 2024
@semd semd self-assigned this Jul 19, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@semd
Copy link
Contributor Author

semd commented Jul 19, 2024

/ci

@semd
Copy link
Contributor Author

semd commented Jul 19, 2024

/ci

@semd
Copy link
Contributor Author

semd commented Jul 19, 2024

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 19, 2024

💔 Build Failed

Failed CI Steps

History

cc @semd

@semd
Copy link
Contributor Author

semd commented Jul 26, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 26, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationImport - 540 +540

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
integrationImport - 39 +39

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB -9.0B
integrationImport - 936.7KB ⚠️ +936.7KB
securitySolution 20.4MB 20.4MB -33.0B
securitySolutionServerless 114.8KB 114.8KB -17.0B
total +936.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
integrationImport - 3 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
integrationImport - 8.7KB +8.7KB
securitySolutionServerless 21.0KB 21.0KB -28.0B
total +8.7KB
Unknown metric groups

API count

id before after diff
integrationImport - 46 +46

async chunk count

id before after diff
integrationImport - 2 +2

ESLint disabled in files

id before after diff
integrationImport - 3 +3

ESLint disabled line counts

id before after diff
integrationImport - 7 +7

miscellaneous assets size

id before after diff
integrationImport - 250.8KB ⚠️ +250.8KB

Total ESLint disabled count

id before after diff
integrationImport - 10 +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants