You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming the code to be consistent with the rebranding of "Integration Assistant" to "Integration Auto Import":
The former integration_assistant plugin has been renamed to integration_import, which exposes different components:
integration_import_card_button: The button displayed at the top right corner of the Integrations page.
integration_import: The top-level page that renders at the /integrations/import* path, former /integration/create*.
integration_import_landing: renders at /integrations/import path, former /integration/create. The landing page of the plugin application.
integration_import_upload: renders at /integrations/import/upload path, former /integration/create/upload. The Zip package upload page.
integration_auto_import: renders at /integrations/import/automatic path, former /integration/create/assistant. This is the actual Automatic Import functionality.
All the component names, variables, plugin references, translation keys... have been refactored to reflect the change.
Exception
The plugin config key has not been changed to prevent current deployments using xpack.integration_assistant.enabled: true from crashing.
To change the config key we would need a config migration. However, since the plan is to enable the plugin by default for 8.16, we can wait until that moment to change the config key and clean all references to xpack.integration_assistant.
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renaming the code to be consistent with the rebranding of "Integration Assistant" to "Integration Auto Import":
The former integration_assistant plugin has been renamed to
integration_import
, which exposes different components:integration_import_card_button
: The button displayed at the top right corner of the Integrations page.integration_import
: The top-level page that renders at the/integrations/import*
path, former/integration/create*
.integration_import_landing
: renders at/integrations/import
path, former/integration/create
. The landing page of the plugin application.integration_import_upload
: renders at/integrations/import/upload
path, former/integration/create/upload
. The Zip package upload page.integration_auto_import
: renders at/integrations/import/automatic
path, former/integration/create/assistant
. This is the actual Automatic Import functionality.All the component names, variables, plugin references, translation keys... have been refactored to reflect the change.
Exception
The plugin config key has not been changed to prevent current deployments using
xpack.integration_assistant.enabled: true
from crashing.To change the config key we would need a config migration. However, since the plan is to enable the plugin by default for 8.16, we can wait until that moment to change the config key and clean all references to
xpack.integration_assistant
.