[Discover][Surrounding Documents] Fix time range filter #187010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
Team:DataDiscovery
…e-range' into 186998-surrounding-documents-time-range
|
/ci |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jughosta |
kertal
approved these changes
Jul 4, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @jughosta |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Jul 4, 2024
- Closes elastic#186998 ## Summary This PR fixes the invalid time range filter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> (cherry picked from commit 8bdee42) # Conflicts: # src/plugins/discover/public/application/context/services/context.predecessors.test.ts # src/plugins/discover/public/application/context/services/context.successors.test.ts
jughosta
added a commit
that referenced
this pull request
Jul 5, 2024
)" This reverts commit 8bdee42.
jughosta
removed
the
backport:prev-minor
jughosta
added
the
backport:prev-minor
jughosta
added
backport:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 5, 2024
- Closes elastic#186998 ## Summary This PR fixes the invalid time range filter. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> (cherry picked from commit 8bdee42)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 6, 2024
…) (#187654) # Backport This will backport the following commits from `main` to `8.15`: - [[Discover][Surrounding Documents] Fix time range filter (#187010)](#187010) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-07-04T13:07:36Z","message":"[Discover][Surrounding Documents] Fix time range filter (#187010)\n\n- Closes #186998 Summary\r\n\r\nThis PR fixes the invalid time range filter.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"8bdee4212bb8e47ec7e998c64bd9c0e9e88c1e3e","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Discover][Surrounding Documents] Fix time range filter","number":187010,"url":"#187010 Documents] Fix time range filter (#187010)\n\n- Closes #186998 Summary\r\n\r\nThis PR fixes the invalid time range filter.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"8bdee4212bb8e47ec7e998c64bd9c0e9e88c1e3e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#187010 Documents] Fix time range filter (#187010)\n\n- Closes #186998 Summary\r\n\r\nThis PR fixes the invalid time range filter.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"8bdee4212bb8e47ec7e998c64bd9c0e9e88c1e3e"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"#187576"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
|
This PR didn't make it on time of the latest v8.15 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the invalid time range filter.
Checklist