-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Change update dataview #183789
Conversation
/ci |
/ci |
/ci |
/ci |
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally - LGTM
Worth noting that after this change is merged the tables won't have the custom naming by default anymore as the UnifiedDataTable does not support custom column naming, only DataView naming. Please create a follow-up ticket to add custom column naming support (Independent from the DataView) to the UnifiedDataTable component.
## Summary Removing Update logic for Findings table from Client Side as well as overriding table column name
## Summary Removing Update logic for Findings table from Client Side as well as overriding table column name (cherry picked from commit 9cb7940)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.14`: - [[Cloud Security] Change update dataview (#183789)](#183789) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-05-22T21:10:38Z","message":"[Cloud Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving Update logic for Findings table from Client Side as well as\r\noverriding table column name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.15.0","v8.14.2"],"title":"[Cloud Security] Change update dataview","number":183789,"url":"https://github.com/elastic/kibana/pull/183789","mergeCommit":{"message":"[Cloud Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving Update logic for Findings table from Client Side as well as\r\noverriding table column name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183789","number":183789,"mergeCommit":{"message":"[Cloud Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving Update logic for Findings table from Client Side as well as\r\noverriding table column name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
## Summary Removing Update logic for Findings table from Client Side as well as overriding table column name (cherry picked from commit 9cb7940)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
4 similar comments
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
Removing Update logic for Findings table from Client Side as well as overriding table column name