Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Add custom column naming support to the UnifiedDataTable component. #184078

Closed
2 tasks
animehart opened this issue May 23, 2024 · 10 comments · Fixed by #184295
Closed
2 tasks

[Cloud Security] Add custom column naming support to the UnifiedDataTable component. #184078

animehart opened this issue May 23, 2024 · 10 comments · Fixed by #184295
Assignees
Labels
8.15 candidate Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture

Comments

@animehart
Copy link
Contributor

animehart commented May 23, 2024

Describe the feature:

This is a follow up ticket from comments made on this PR (#183789)
Due to the change we made on the said PR, tables won't have the custom naming by default anymore as the UnifiedDataTable does not support custom column naming.

We should add custom column naming support (Independent from the DataView) to the UnifiedDataTable component.

Definition of Done:

  • Create a Custom Column Naming support for the UnifiedDataTable component
  • Make sure the FTRs still works

How to Test:
Pre-req: Need Findings data

  • Create User with read only permissions
  • Login with that User and then navigate to Findings page
  • User should be able to see Findings table with no problem
@animehart animehart added the Team:Cloud Security Cloud Security team related label May 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kfirpeled kfirpeled added technical debt Improvement of the software architecture and operational architecture 8.15 candidate labels Jun 5, 2024
@amirbenun
Copy link
Contributor

Trying to verify as part of QA:

  1. Creating a new user with "viewer" role
    Image

  2. findings page is stuck on "loading results" state
    Image

@oren-zohar
Copy link
Contributor

@kfirpeled @animehart @opauloh should we re-open this ticket?

@oren-zohar oren-zohar reopened this Jul 15, 2024
@kfirpeled
Copy link
Contributor

@animehart pay attention this ticket was re-opened after the first QA cycle, can you take a look and estimate what's the issue?

@animehart
Copy link
Contributor Author

animehart commented Jul 15, 2024

@kfirpeled
So I checked on this issue and it appears that this issue is being caused when users only has 'read' access to Fleet. This is causing the user to receive error 403 (Forbidden) whenever they try to access the findings page as shown below
Screenshot 2024-07-15 at 9 29 38 AM

@kfirpeled
Copy link
Contributor

Thanks @animehart , in that case can you please open another ticket for this?
And you can close this one and we will verify it again on our next QA cycle

@opauloh
Copy link
Contributor

opauloh commented Jul 15, 2024

@kfirpeled So I checked on this issue and it appears that this issue is being caused when users only has 'read' access to Fleet. This is causing the user to receive error 403 (Forbidden) whenever they try to access the findings page as shown below Screenshot 2024-07-15 at 9 29 38 AM

Yes, the problem is caused by this line. @CohenIdo do we really need this checking !(await context.fleet).authz.fleet.all in this API?

Actually, I see we have authz.fleet.* checking across a couple of CSP APIs, but I could not find a documentation with the reason why we started adding this check in the first place. It doesn't look like a common practice for other plugins other than the fleet plugin. I've seen only a couple of use cases where this API is used out of the fleet plugin when there's a need to display agent polices to the users or update agent polices, but the CSP plugin does have an use case where it needs to display or update agent polices without using the fleet API.

cc @kfirpeled

@opauloh
Copy link
Contributor

opauloh commented Jul 15, 2024

I added a Tech Debt ticket for us to review authz.fleet.* usage in the CSP plugin.

I also see that this issue happens on 8.14.3 where users with viewer permission can access the CSP Dashboard, but can't see benchmarks or misconfiguration data on the findings page.

image image image

@opauloh
Copy link
Contributor

opauloh commented Jul 26, 2024

Verified 8.15.0 BC 4

Details on the comment:

#172615 (comment)

@maxcold
Copy link
Contributor

maxcold commented Jul 30, 2024

The issue with access roles exist on serverless, new ticket is opened:

Marking this ticket as verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.15 candidate Team:Cloud Security Cloud Security team related technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants