Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Hover actions for panels #182535

Merged
merged 133 commits into from
Oct 25, 2024
Merged

[Dashboard] Hover actions for panels #182535

merged 133 commits into from
Oct 25, 2024
+1,349 −737

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented May 2, 2024 •
edited by kibanamachine
Loading

Summary

Closes #151233.
Closes #175451.
Closes #169677.
Closes #185893.

This updates the design for the actions menu for dashboard panels. With this new design, the most common actions are promoted and available as you hover over the panels.

Screenshot 2024-08-12 at 1 01 45 PM

The remaining actions are available in a context menu similar to the one that exists today but with better organized sections.

Jun-12-2024 16-33-23

Notable changes:

  • Switch from context menu in panel title bar to hover actions
  • Add groupings to actions for organized sections in actions menu
  • Turn off CSS transforms on react-grid-layout
  • Hide title bar in edit mode when panel title disabled unless badges or notifications are visible
  • Renamed PresentationPanelContextMenu -> PresentationPanelHoverActions
  • Promote Explore in Discover action for Lens panels
  • Show panel filter notification in view mode and edit mode
  • Use discoverApp icon for actions that redirect to Discover

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 changed the title [POC][Dashboard] Floating actions for panels [POC][Dashboard] Hover actions for panels May 3, 2024
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 93789ae to 7691975 Compare May 6, 2024 15:40
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch 3 times, most recently from c92d076 to 34add9d Compare May 24, 2024 20:00
@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 29, 2024
@cqliu1 cqliu1 changed the title [POC][Dashboard] Hover actions for panels [Dashboard] Hover actions for panels May 31, 2024
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 4b90167 to 3d5defd Compare June 4, 2024 18:50
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from c1da327 to 6924815 Compare June 12, 2024 22:50
This was referenced Jun 13, 2024
Open
Open
@Heenawter Heenawter mentioned this pull request Jun 18, 2024
Closed
@mgiota mgiota mentioned this pull request Jun 21, 2024
Merged
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch 2 times, most recently from cb77397 to 16ff27d Compare July 17, 2024 15:24
@teresaalvarezsoler teresaalvarezsoler mentioned this pull request Jul 23, 2024
Open
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from af90b9f to c28d3cc Compare July 24, 2024 17:19
@cqliu1
Copy link
Contributor Author

cqliu1 commented Jul 25, 2024

/ci

@rshen91 rshen91 mentioned this pull request Jul 25, 2024
Draft
14 tasks
@andreadelrio andreadelrio mentioned this pull request Jul 26, 2024
Merged
6 tasks
@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from c70f2a5 to 43feba8 Compare July 31, 2024 22:59
@teresaalvarezsoler teresaalvarezsoler mentioned this pull request Aug 2, 2024
Open
@cqliu1
Copy link
Contributor Author

cqliu1 commented Aug 3, 2024

/ci

@cqliu1 cqliu1 force-pushed the dashboard/floating-actions-for-panels branch from 9d93ea8 to 1d78ce5 Compare August 3, 2024 03:18
@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 22, 2024 •
edited
Loading

Expanding a panel appears to be broken sometimes 😢 Hopefully it is a quick fix

It was an issue with the tooltip on the expand hover action losing it's anchor element but still rendering on the page. I fixed it with a46f023 by blurring the action target element on click.

@cqliu1 cqliu1 mentioned this pull request Oct 22, 2024
Open
@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 22, 2024 •
edited
Loading

  • Noticed a slightly awkward interaction with range sliders where, if you drag a panel over the minimum value, it opens the popover:
    Oct-22-2024 08-22-50

I opened an issue to address this in a follow up PR #197306.

Heenawter
Heenawter approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Thanks so much for your hard work on this 🙇 So excited to see this finally ready to be merged.

@nickofthyme
Copy link
Contributor

@elastic/obs-ux-management-team would have any idea as to why this Synthetics @elastic/synthetics Tests here is repeatedly failing?

@shahzad31
Copy link
Contributor

@elastic/obs-ux-management-team would have any idea as to why this Synthetics @elastic/synthetics Tests here is repeatedly failing?

@nickofthyme i have rebased, it was already fixed in main

@nickofthyme
Copy link
Contributor

Amazing! Thanks @shahzad31

@cqliu1 cqliu1 requested a review from a team as a code owner October 25, 2024 04:22
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 98a7323
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-182535-98a732374f67

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 583 584 +1
apm 1880 1881 +1
canvas 1288 1289 +1
cases 812 813 +1
controls 356 357 +1
dashboard 674 675 +1
dashboardEnhanced 95 96 +1
dataVisualizer 728 729 +1
discover 1000 1001 +1
discoverEnhanced 44 45 +1
embeddable 142 143 +1
embeddableEnhanced 44 45 +1
imageEmbeddable 140 141 +1
infra 1527 1528 +1
inputControlVis 93 94 +1
lens 1468 1469 +1
links 130 131 +1
maps 1241 1242 +1
ml 2036 2037 +1
presentationPanel 104 105 +1
presentationUtil 179 180 +1
reporting 151 152 +1
securitySolution 6044 6045 +1
slo 850 851 +1
synthetics 1034 1035 +1
urlDrilldown 46 47 +1
visualizations 477 478 +1
total +27

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 183 188 +5
embeddable 465 468 +3
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +1.4KB
dashboard 643.0KB 646.0KB +3.0KB
exploratoryView 182.6KB 182.7KB +40.0B
lens 1.5MB 1.5MB +137.0B
links 52.4KB 52.4KB +20.0B
ml 4.5MB 4.5MB +37.0B
presentationPanel 9.1KB 14.2KB +5.2KB
total +9.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 151.2KB 151.2KB +41.0B
dashboard 50.4KB 51.8KB +1.3KB
dashboardEnhanced 17.8KB 17.9KB +80.0B
discover 50.6KB 50.7KB +25.0B
embeddable 71.7KB 72.0KB +348.0B
lens 51.4KB 51.6KB +233.0B
presentationPanel 44.0KB 46.4KB +2.3KB
uiActions 23.4KB 23.5KB +72.0B
uiActionsEnhanced 17.3KB 17.3KB -1.0B
total +4.4KB
Unknown metric groups

API count

id before after diff
@kbn/presentation-publishing 218 224 +6
embeddable 575 578 +3
total +9

History

@cqliu1 cqliu1 merged commit 2fdfb8d into elastic:main Oct 25, 2024
32 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11514249156

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@cqliu1
[Dashboard] Hover actions for panels (elastic#182535)
908ae96 
(cherry picked from commit 2fdfb8d)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @cqliu1
[8.x] [Dashboard] Hover actions for panels (#182535) (#197770)
d05d659 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dashboard] Hover actions for panels
(#182535)](#182535)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:59:41Z","message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Feature:Embedding","Team:Presentation","loe:large","impact:medium","Feature:Drilldowns","v9.0.0","Project:Dashboard
Usability","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0"],"title":"[Dashboard]
Hover actions for
panels","number":182535,"url":"https://github.com/elastic/kibana/pull/182535","mergeCommit":{"message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182535","number":182535,"mergeCommit":{"message":"[Dashboard]
Hover actions for panels
(#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
@cqliu1 cqliu1 deleted the dashboard/floating-actions-for-panels branch October 25, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@eokoneyo eokoneyo eokoneyo left review comments

@kertal kertal kertal approved these changes

@tsullivan tsullivan tsullivan approved these changes

@pheyos pheyos pheyos approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

@delanni delanni delanni approved these changes

@peteharverson peteharverson peteharverson approved these changes

@cnasikas cnasikas cnasikas approved these changes

@Heenawter Heenawter Heenawter approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative release_note:enhancement Team:obs-ux-management Observability Management User Experience Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone