-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Hover actions for panels #182535
[Dashboard] Hover actions for panels #182535
Conversation
93789ae
to
7691975
Compare
c92d076
to
34add9d
Compare
4b90167
to
3d5defd
Compare
c1da327
to
6924815
Compare
cb77397
to
16ff27d
Compare
af90b9f
to
c28d3cc
Compare
/ci |
c70f2a5
to
43feba8
Compare
/ci |
9d93ea8
to
1d78ce5
Compare
It was an issue with the tooltip on the expand hover action losing it's anchor element but still rendering on the page. I fixed it with a46f023 by blurring the action target element on click. |
I opened an issue to address this in a follow up PR #197306. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!! Thanks so much for your hard work on this 🙇 So excited to see this finally ready to be merged.
…b.com/cqliu1/kibana into dashboard/floating-actions-for-panels
@elastic/obs-ux-management-team would have any idea as to why this |
@nickofthyme i have rebased, it was already fixed in main |
Amazing! Thanks @shahzad31 |
…b.com/cqliu1/kibana into dashboard/floating-actions-for-panels
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11514249156 |
(cherry picked from commit 2fdfb8d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard] Hover actions for panels (#182535)](#182535) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Catherine Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2024-10-25T07:59:41Z","message":"[Dashboard] Hover actions for panels (#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Feature:Embedding","Team:Presentation","loe:large","impact:medium","Feature:Drilldowns","v9.0.0","Project:Dashboard Usability","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0"],"title":"[Dashboard] Hover actions for panels","number":182535,"url":"https://github.com/elastic/kibana/pull/182535","mergeCommit":{"message":"[Dashboard] Hover actions for panels (#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182535","number":182535,"mergeCommit":{"message":"[Dashboard] Hover actions for panels (#182535)","sha":"2fdfb8d769442a7591e982a0dcff40fb8eb1699a"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Summary
Closes #151233.
Closes #175451.
Closes #169677.
Closes #185893.
This updates the design for the actions menu for dashboard panels. With this new design, the most common actions are promoted and available as you hover over the panels.
The remaining actions are available in a context menu similar to the one that exists today but with better organized sections.
Notable changes:
PresentationPanelContextMenu
->PresentationPanelHoverActions
Explore in Discover
action for Lens panelsdiscoverApp
icon for actions that redirect to DiscoverChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers