Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove PANEL_BADGE_TRIGGER trigger #186202

Open
cqliu1 opened this issue Jun 13, 2024 · 1 comment
Open

[Dashboard] Remove PANEL_BADGE_TRIGGER trigger #186202

cqliu1 opened this issue Jun 13, 2024 · 1 comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Jun 13, 2024

Currently badges can be registered to the PANEL_BADGE_TRIGGER trigger and appear on relevant panels as part of the panel title bar. As our designs are moving away from displaying a title bar on panels without a title, we should reconsider how we handle badges and remove the trigger.

There are only two actions registered to the PANEL_BADGE_TRIGGER, the custom time range badge and the deprecation badge displayed on legacy input controls. As part of #152025, we want to remove the custom time range badge and adding the custom time range to the panel filters popover. The deprecation badge can also be removed and rendered as part of the controls embeddable.

Since we're planning to remove these two badges, we should remove the PANEL_BADGE_TRIGGER entirely. With our updated designs as part of #182535, any future "badges" should be added to the hover actions or actions context menu.

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 13, 2024
@bhavyarm bhavyarm added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jun 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 13, 2024
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Dashboard Usability Related to the Dashboard Usability initiative labels Jun 13, 2024
@ThomThomson ThomThomson added the loe:small Small Level of Effort label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Usability Related to the Dashboard Usability initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants