[expressions] caching

[ppisljar]

Summary

adds caching support to expressions. Functions can set allowCaching property to true to indicate they can/should be cached.

When an expression is executed with allowCaching parameter set to true the expression engine will cache results of such functions and reuse them in later executions of expression if:

• input did not change
• arguments did not change
• search context did not change
• cache did not time out

fix #177548

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[ppisljar]

/ci

[ppisljar]

/ci

[ppisljar]

/ci

[ppisljar]

/ci

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[stratoula]

What a lovely PR improving the experience of our apps 😍

I was mostly focused on the ES|QL experience which was works exactly as I am expecting. I also tested the dataview mode and everything seems to work great except from annotations.

Here I tried to add an annotations layer from the dashboard inline editing.

@dej611 @mbondyra I think it would be great both of you to test this PR to ensure that everything works as expected!

[stratoula]

@ppisljar I can't reproduce it now 🤔 Annotations work great in my new tests!

[dej611]

Tested thoroughly and found only one issue with absolute shifting in formula.

This is what I get in this PR:

This is what it should show instead:

[stratoula]

one bug only is very good news 🎉

[lukasolson]

I'm noticing an odd behavior:

1. Add a delay to the query
2. Let the query complete, then change the colors (they change just fine without re-issuing the query)
3. Refresh the query
4. Before the query completes, try to change the colors (you get "no results found")

I tried to reproduce on main and I couldn't, so I'm pretty sure this has to do with this PR. It looks like the query is being cancelled for some reason.

Untitled.mov

[ppisljar]

good catch @lukasolson ! I updated the code with a check to make sure we only cache the last result from the observable and we are not caching partial results.

[dej611]

Tested out again and cannot find issues so far 👍

[lukasolson]

LGTM!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: cdff981

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
expressions	1756	1763	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.5MB	1.5MB	+940.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
expressions	5	6	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	419.0KB	419.0KB	+70.0B
expressions	98.6KB	99.5KB	+858.0B
total			+928.0B

Unknown metric groups

API count

id	before	after	diff
expressions	2217	2233	+16

History

• 💚 Build #210356 succeeded 5515d1b
• 💛 Build #209723 was flaky 485c089
• 💔 Build #209560 failed d460f07
• 💔 Build #209455 failed f820160
• 💚 Build #208916 succeeded 6384ecb
• 💔 Build #208905 failed 648eefc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[markov00]

changes looks good to me, great work here!