Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Do not run the fetch request when the user changes chart configuration #177548

Closed
stratoula opened this issue Feb 22, 2024 · 4 comments · Fixed by #180440
Closed

[Lens] Do not run the fetch request when the user changes chart configuration #177548

stratoula opened this issue Feb 22, 2024 · 4 comments · Fixed by #180440
Assignees
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:

Lens is architectured with that way so every time a user is making a change, the expression reruns again. This means that we are requesting the data again although the user might want to only change a color.

In dataview mode, this is fixed with the search sessions but with ES|QL this problem has been surfaced again. I would like only the expression regarding the chart configuration to run and not everything but without introducing search sessions in ES|QL.

meow

I am labelling this as a feature request, mostly because I expect this to be a quite big change but I think that is an annoying behavior we should prioritize

@stratoula stratoula added Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2024
@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana and removed needs-team Issues missing a team label labels Feb 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2024
@stratoula stratoula added performance and removed needs-team Issues missing a team label labels Feb 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2024
@stratoula stratoula added enhancement New value added to drive a business result and removed needs-team Issues missing a team label labels Feb 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 22, 2024
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 22, 2024
@dej611
Copy link
Contributor

dej611 commented Feb 22, 2024

Can't we reuse the same memoization technique used for the autocomplete here at expression level? i.e. same query for the next 10 secs has the same result.
Of course come forcing flag would be required for some use cases.

@stratoula
Copy link
Contributor Author

stratoula commented Feb 22, 2024

I think the best way to do it (also discussed briefly with Peter) is to not run the bsearch for this kind of changes (as we did in Discover where we are passing the datatable in the expression). We will investigate with @ppisljar but I think this is the correct path forward. In my mind this is something we need to take care holistically and not only for ES|QL. If we deprecate search sessions (are they even available in serverless?) then the dataview mode will also have problems

@stratoula
Copy link
Contributor Author

I asked the Discovery team and search sessions are not enabled in serverless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants