Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sentinel_one] Fix agent status field name in Alert details highlighted fields #174421

Merged
merged 6 commits into from
Jan 12, 2024
Merged

[sentinel_one] Fix agent status field name in Alert details highlighted fields #174421

merged 6 commits into from
Jan 12, 2024

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jan 7, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #174235

image

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner January 7, 2024 10:19
@patrykkopycinski patrykkopycinski self-assigned this Jan 7, 2024
@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.12.1 v8.13.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 7, 2024
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner January 7, 2024 12:38
@patrykkopycinski patrykkopycinski mentioned this pull request Jan 8, 2024
Draft
@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Jan 8, 2024 •
edited
Loading

@patrykkopycinski I just realized that the changes in this PR are also in #174423

I left a few comments there, sorry!

In the future, can you make sure to explicitly mention this in the PR description? Follow up to #... to me doesn't necessarily means it requires the other PR to be merged first. A follow can just be the pursue of a previous work already done!

vitaliidm
vitaliidm reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection engine area LGTM

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner January 12, 2024 01:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.4MB +478.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

PhilippeOberti
PhilippeOberti approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thank you for adding all the unit tests!!

@patrykkopycinski patrykkopycinski merged commit 5344f86 into elastic:main Jan 12, 2024
37 checks passed
@patrykkopycinski patrykkopycinski deleted the fix/sentinel-one-agent-status branch January 12, 2024 23:03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 12, 2024
@patrykkopycinski
[sentinel_one] Fix agent status field name in Alert details highlight…
5df3a39 
…ed fields (elastic#174421)

## Summary

Fixes elastic#174235

<img width="1809" alt="image"
src="https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c">

(cherry picked from commit 5344f86)
@kibanamachine kibanamachine mentioned this pull request Jan 12, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 13, 2024
@kibanamachine @patrykkopycinski
[8.12] [sentinel_one] Fix agent status field name in Alert details hi…
68739f9 
…ghlighted fields (#174421) (#174802)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[sentinel_one] Fix agent status field name in Alert details
highlighted fields
(#174421)](#174421)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-01-12T23:03:06Z","message":"[sentinel_one]
Fix agent status field name in Alert details highlighted fields
(#174421)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/174235\r\n\r\n<img
width=\"1809\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.12.1","v8.13.0"],"title":"[sentinel_one]
Fix agent status field name in Alert details highlighted
fields","number":174421,"url":"https://github.com/elastic/kibana/pull/174421","mergeCommit":{"message":"[sentinel_one]
Fix agent status field name in Alert details highlighted fields
(#174421)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/174235\r\n\r\n<img
width=\"1809\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174421","number":174421,"mergeCommit":{"message":"[sentinel_one]
Fix agent status field name in Alert details highlighted fields
(#174421)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/174235\r\n\r\n<img
width=\"1809\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac"}}]}]
BACKPORT-->

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
@mistic mistic removed the v8.12.0 label Jan 17, 2024
@mistic
Copy link
Member

mistic commented Jan 17, 2024

This PR didn't make it into the latest BC for 8.12.0. Updating the labels.

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@patrykkopycinski @CoenWarmer
[sentinel_one] Fix agent status field name in Alert details highlight…
4f68ba9 
…ed fields (elastic#174421)

## Summary

Fixes elastic#174235

<img width="1809" alt="image"
src="https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@vitaliidm vitaliidm vitaliidm approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
6 participants
@patrykkopycinski @PhilippeOberti @kibana-ci @kibanamachine @mistic @vitaliidm