-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sentinel_one] Fix agent status field name in Alert details highlighted fields #174421
[sentinel_one] Fix agent status field name in Alert details highlighted fields #174421
Conversation
@patrykkopycinski I just realized that the changes in this PR are also in #174423 I left a few comments there, sorry! In the future, can you make sure to explicitly mention this in the PR description? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection engine area LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thank you for adding all the unit tests!!
…ed fields (elastic#174421) ## Summary Fixes elastic#174235 <img width="1809" alt="image" src="https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c"> (cherry picked from commit 5344f86)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ghlighted fields (#174421) (#174802) # Backport This will backport the following commits from `main` to `8.12`: - [[sentinel_one] Fix agent status field name in Alert details highlighted fields (#174421)](#174421) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-01-12T23:03:06Z","message":"[sentinel_one] Fix agent status field name in Alert details highlighted fields (#174421)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/174235\r\n\r\n<img width=\"1809\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.12.1","v8.13.0"],"title":"[sentinel_one] Fix agent status field name in Alert details highlighted fields","number":174421,"url":"https://github.com/elastic/kibana/pull/174421","mergeCommit":{"message":"[sentinel_one] Fix agent status field name in Alert details highlighted fields (#174421)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/174235\r\n\r\n<img width=\"1809\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174421","number":174421,"mergeCommit":{"message":"[sentinel_one] Fix agent status field name in Alert details highlighted fields (#174421)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/174235\r\n\r\n<img width=\"1809\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c\">","sha":"5344f86769536b901c19d6ce894c5b614a3836ac"}}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
This PR didn't make it into the latest BC for 8.12.0. Updating the labels. |
…ed fields (elastic#174421) ## Summary Fixes elastic#174235 <img width="1809" alt="image" src="https://github.com/elastic/kibana/assets/5188868/43f120c7-8bbd-4e5a-9824-5db4fda9f35c">
Summary
Fixes #174235