add unit tests

elastic · Jan 12, 2024 · d5310f9 · d5310f9
1 parent e32eee8
commit d5310f9
Show file tree

Hide file tree

Showing 4 changed files with 132 additions and 3 deletions.
diff --git a/...curity_solution/public/detections/components/host_isolation/sentinel_one_agent_status.tsx b/...curity_solution/public/detections/components/host_isolation/sentinel_one_agent_status.tsx
@@ -45,7 +45,7 @@ const EuiFlexGroupStyled = styled(EuiFlexGroup)`
 `;
 
 export const SentinelOneAgentStatus = React.memo(
-  ({ agentId, dataTestSubj }: { agentId: string; dataTestSubj?: string }) => {
+  ({ agentId, 'data-test-subj': dataTestSubj }: { agentId: string; 'data-test-subj'?: string }) => {
     const { data, isFetched } = useSentinelOneAgentData({ agentId });
 
     const label = useMemo(() => {

diff --git a/...solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx b/...solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx
@@ -20,8 +20,10 @@ import { LeftPanelInsightsTab, DocumentDetailsLeftPanelKey } from '../../left';
 import { TestProviders } from '../../../../common/mock';
 import { ENTITIES_TAB_ID } from '../../left/components/entities_details';
 import { useGetEndpointDetails } from '../../../../management/hooks';
+import { useSentinelOneAgentData } from '../../../../detections/components/host_isolation/use_sentinelone_host_isolation';
 
 jest.mock('../../../../management/hooks');
+jest.mock('../../../../detections/components/host_isolation/use_sentinelone_host_isolation');
 
 const flyoutContextValue = {
   openLeftPanel: jest.fn(),
@@ -86,7 +88,22 @@ describe('<HighlightedFieldsCell />', () => {
     expect(getByTestId(HIGHLIGHTED_FIELDS_AGENT_STATUS_CELL_TEST_ID)).toBeInTheDocument();
   });
 
-  it('should render agent status component if override field is agent.status', () => {
+  it('should render sentinelone agent status cell if field is agent.status and origialField is observer.serial_number', () => {
+    (useSentinelOneAgentData as jest.Mock).mockReturnValue({ isFetched: true });
+    const { getByTestId } = render(
+      <TestProviders>
+        <HighlightedFieldsCell
+          values={['value']}
+          field={'agent.status'}
+          originalField="observer.serial_number"
+        />
+      </TestProviders>
+    );
+
+    expect(getByTestId(HIGHLIGHTED_FIELDS_AGENT_STATUS_CELL_TEST_ID)).toBeInTheDocument();
+  });
+
+  it('should not render if values is null', () => {
     const { container } = render(<HighlightedFieldsCell values={null} field={'field'} />);
 
     expect(container).toBeEmptyDOMElement();

diff --git a/...rity_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx b/...rity_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx
@@ -97,7 +97,10 @@ export const HighlightedFieldsCell: VFC<HighlightedFieldsCellProps> = ({
               <LinkFieldCell value={value} />
             ) : field === AGENT_STATUS_FIELD_NAME &&
               originalField === SENTINEL_ONE_AGENT_ID_FIELD ? (
-              <SentinelOneAgentStatus agentId={String(value ?? '')} />
+              <SentinelOneAgentStatus
+                agentId={String(value ?? '')}
+                data-test-subj={HIGHLIGHTED_FIELDS_AGENT_STATUS_CELL_TEST_ID}
+              />
             ) : field === AGENT_STATUS_FIELD_NAME ? (
               <EndpointAgentStatusById
                 endpointAgentId={String(value ?? '')}

diff --git a/...rity_solution/public/flyout/document_details/shared/hooks/use_highlighted_fields.test.tsx b/...rity_solution/public/flyout/document_details/shared/hooks/use_highlighted_fields.test.tsx
@@ -9,6 +9,7 @@ import { renderHook } from '@testing-library/react-hooks';
 
 import { mockDataFormattedForFieldBrowser } from '../mocks/mock_data_formatted_for_field_browser';
 import { useHighlightedFields } from './use_highlighted_fields';
+import { SENTINEL_ONE_AGENT_ID_FIELD } from '../../../../common/utils/sentinelone_alert_check';
 
 const dataFormattedForFieldBrowser = mockDataFormattedForFieldBrowser;
 
@@ -21,4 +22,112 @@ describe('useHighlightedFields', () => {
       },
     });
   });
+
+  it('should omit endpoint agent id field if data is not s1 alert', () => {
+    const hookResult = renderHook(() =>
+      useHighlightedFields({
+        dataFormattedForFieldBrowser: dataFormattedForFieldBrowser.concat({
+          category: 'agent',
+          field: 'agent.id',
+          values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+          originalValue: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+          isObjectArray: false,
+        }),
+        investigationFields: ['agent.status', 'agent.id'],
+      })
+    );
+
+    expect(hookResult.result.current).toEqual({
+      'kibana.alert.rule.type': {
+        values: ['query'],
+      },
+    });
+  });
+
+  it('should return endpoint agent id field if data is s1 alert', () => {
+    const hookResult = renderHook(() =>
+      useHighlightedFields({
+        dataFormattedForFieldBrowser: dataFormattedForFieldBrowser.concat([
+          {
+            category: 'agent',
+            field: 'agent.type',
+            values: ['endpoint'],
+            originalValue: ['endpoint'],
+            isObjectArray: false,
+          },
+          {
+            category: 'agent',
+            field: 'agent.id',
+            values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+            originalValue: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+            isObjectArray: false,
+          },
+        ]),
+        investigationFields: ['agent.status', 'agent.id'],
+      })
+    );
+
+    expect(hookResult.result.current).toEqual({
+      'kibana.alert.rule.type': {
+        values: ['query'],
+      },
+      'agent.id': {
+        values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+      },
+    });
+  });
+
+  it('should omit sentinelone agent id field if data is not s1 alert', () => {
+    const hookResult = renderHook(() =>
+      useHighlightedFields({
+        dataFormattedForFieldBrowser: dataFormattedForFieldBrowser.concat({
+          category: 'observer',
+          field: `observer.${SENTINEL_ONE_AGENT_ID_FIELD}`,
+          values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+          originalValue: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+          isObjectArray: false,
+        }),
+        investigationFields: ['agent.status', 'observer.serial_number'],
+      })
+    );
+
+    expect(hookResult.result.current).toEqual({
+      'kibana.alert.rule.type': {
+        values: ['query'],
+      },
+    });
+  });
+
+  it('should return sentinelone agent id field if data is s1 alert', () => {
+    const hookResult = renderHook(() =>
+      useHighlightedFields({
+        dataFormattedForFieldBrowser: dataFormattedForFieldBrowser.concat([
+          {
+            category: 'event',
+            field: 'event.module',
+            values: ['sentinel_one'],
+            originalValue: ['sentinel_one'],
+            isObjectArray: false,
+          },
+          {
+            category: 'observer',
+            field: SENTINEL_ONE_AGENT_ID_FIELD,
+            values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+            originalValue: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+            isObjectArray: false,
+          },
+        ]),
+        investigationFields: ['agent.status', 'observer.serial_number'],
+      })
+    );
+
+    expect(hookResult.result.current).toEqual({
+      'kibana.alert.rule.type': {
+        values: ['query'],
+      },
+      'observer.serial_number': {
+        values: ['deb35a20-70f8-458e-a64a-c9e6f7575893'],
+      },
+    });
+  });
 });