Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Explore cypress, fix more flakes #173539

Closed
wants to merge 17 commits into from
Closed

[Security solution] Explore cypress, fix more flakes #173539

wants to merge 17 commits into from

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Dec 18, 2023 •
edited
Loading

Summary

Fixes these flakey tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4523#_

Test Failures
[job] [logs] Security Solution Explore - Cypress #64 / Alerts timeline Privileges: can crud "before each" hook for "should allow a user with crud privileges to attach alerts to cases" "before each" hook for "should allow a user with crud privileges to attach alerts to cases"
[job] [logs] Security Solution Explore - Cypress #64 / Alerts timeline Privileges: read only "before each" hook for "should not allow user with read only privileges to attach alerts to a new case" "before each" hook for "should not allow user with read only privileges to attach alerts to a new case"
[job] [logs] Security Solution Explore - Cypress #54 / Guided onboarding tour "before each" hook for "Completes the tour with action clicks" "before each" hook for "Completes the tour with action clicks"

Flakey test runner build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4621

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.13.0 labels Dec 18, 2023
@stephmilovic stephmilovic requested a review from a team as a code owner December 18, 2023 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic stephmilovic requested a review from a team as a code owner April 22, 2024 12:02
angorayc
angorayc reviewed Apr 22, 2024
View reviewed changes
x-pack/plugins/security_solution/public/common/components/event_details/osquery_tab.tsx
@@ -47,7 +47,7 @@ export const useOsqueryTab = ({
: undefined;

const responseActions =
expandedEventFieldsObject?.kibana?.alert?.rule?.parameters?.[0].response_actions;
expandedEventFieldsObject?.kibana?.alert?.rule?.parameters?.[0]?.response_actions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this error when fixing Cypress tests for guided onboarding tour
Screenshot 2024-04-22 at 12 48 12

@angorayc
Copy link
Contributor

Found that the guided onboarding tour doen't work with the new expendable flyout. We have to bring the missing tour steps back and the tour should still be compatible with the old flyout. #181442

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +168.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc
Copy link
Contributor

angorayc commented Apr 30, 2024 •
edited
Loading

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5823

Screenshot 2024-05-01 at 10 02 46

@angorayc angorayc enabled auto-merge (squash) May 1, 2024 09:18
@angorayc angorayc added v8.15.0 and removed v8.13.0 labels May 1, 2024
auto-merge was automatically disabled September 12, 2024 16:19

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc left review comments

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephmilovic @elasticmachine @angorayc @kibana-ci @michaelolo24 @kibanamachine