[Synthetics] Process processors in kibana as yaml #162812
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
added
release_note:skip
botelastic
bot
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/uptime (Team:uptime) |
| if (enabledStream.vars) { | ||
| const processors = processorsFormatter(enabledStream.vars); | ||
| enabledStream.vars.processors = { value: processors, type: 'yaml' }; | ||
| enabledStream.compiled_stream.processors = processors; | ||
| } |
There was a problem hiding this comment.
I'm not sure how the values being set here are used, but if we imagine Kibana N-1 running at the same time as Kibana N, would Kibana N-1 possibly be setting these fields to different values? Does it know that they exist?
There was a problem hiding this comment.
This is more intended as a thought experiment ;) we want to be careful about mutating fields in a way that could cause issues if multiple different versions of Kibana are running against the same cluster.
There was a problem hiding this comment.
@jloleysens can you please elaborate? :)
There was a problem hiding this comment.
Thanks for making those changes, offline we also discussed the known "update" limitation and looks like this case is safe.
...core/server/integration_tests/saved_objects/migrations/group2/check_registered_types.test.ts
Outdated
Show resolved
Hide resolved
…up2/check_registered_types.test.ts
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
We add few fields like test_run_id and run_once etc from kibana via
add_fieldsprocessor. Instead of passing all fields separately, we will now generate yaml on kibana , this is more extendable.depends on elastic/integrations#7196
Testing
Make sure processors is still added to private location config, you can view that when do inspect monitor in add/edit form
