Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Move processors to kibana #7196

Merged
merged 4 commits into from
Jul 31, 2023
Merged

[Synthetics] Move processors to kibana #7196

merged 4 commits into from
Jul 31, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 31, 2023 •
edited
Loading

Instead of adding individual fields to processors, we will generate those as yaml in kibana !!

Relevant kibana PR elastic/kibana#162812 !!

@shahzad31 shahzad31 mentioned this pull request Jul 31, 2023
Merged
@shahzad31 shahzad31 marked this pull request as ready for review July 31, 2023 15:29
@shahzad31 shahzad31 requested a review from a team as a code owner July 31, 2023 15:29
@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-31T16:10:31.446+0000

  • Duration: 16 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (6/18) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

emilioalvap
emilioalvap approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

awahab07
awahab07 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 3e2524f into main Jul 31, 2023
1 check passed
@shahzad31 shahzad31 deleted the processors branch July 31, 2023 19:13
@elasticmachine
Copy link

Package synthetics - 1.0.4 containing this change is available at https://epr.elastic.co/search?package=synthetics

gizas pushed a commit that referenced this pull request Sep 5, 2023
@shahzad31 @gizas
[Synthetics] Move processors to kibana (#7196)
2c62899
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 11, 2023
Closed
5 tasks
@andrewkroh andrewkroh added the Integration:synthetics Elastic Synthetics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

@emilioalvap emilioalvap emilioalvap approved these changes

Assignees
No one assigned
Labels
Integration:synthetics Elastic Synthetics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @awahab07 @emilioalvap @andrewkroh