-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Share link feature #148829
Merged
Merged
[Lens] Share link feature #148829
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
86c87b1
:sparkles: Add new share feature to Lens
dej611 541dde9
Merge branch 'main' into feature/75316-2
dej611 6213e71
:white_check_mark: Add support for adhoc dataviews + tests
dej611 b3c3de2
:bug: Fix a bug when dataView specs were passed
dej611 50470ee
:white_check_mark: Fix functional test
dej611 d707b94
:bug: Fix reloading of saved chart when shared
dej611 2b0a905
:white_check_mark: Fix explore tests broken
dej611 8622644
:bug: Fix functional test issue
dej611 8bec385
Update x-pack/plugins/lens/public/app_plugin/csv_download_provider/cs…
dej611 dd8bb76
Update x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx
dej611 1daa5e3
Update x-pack/plugins/lens/public/app_plugin/csv_download_provider/cs…
dej611 4df7ab8
Merge branch 'main' into feature/75316-2
stratoula 1130511
Apply suggestions from code review
dej611 2cf9fdc
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine aee37dd
:label: Fix type issue
dej611 d3c344d
:bug: Sync time range from shared state
dej611 1238515
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
130 changes: 130 additions & 0 deletions
130
src/plugins/share/public/components/__snapshots__/share_context_menu.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: how about setting
shareableUrlForSavedObject
to default value of '', and then this whole line can be simplified to:url = this.props.shareableUrlForSavedObject
? Or even better:const url = this.props.shareableUrlForSavedObject ?? (this.props.shareableUrl) || window.location.href)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand exactly what you propose.
Given a default value of
''
forshareableUrlForSavedObject
, and this line changing to:Then any snapshot url would depend on
shareableUrlForSavedObject
, which is not what I need. TheshareableUrlForSavedObject
should be used only when theforSavedObject
flag is on, not every time a snapshot URL is asked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah fair, I thought
forSavedObject
was always set to true, because other lines were collapsed 😬