Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing in popovers in Rule Detail and Alert Detail as a result of Eui spacing updates #146144

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Nov 23, 2022

Resolves #145987

Summary

This fixes spacing in the popovers in Rule Detail and Alert Detail header actions components.

Screenshot 2022-11-23 at 13 09 07

@CoenWarmer CoenWarmer requested a review from a team as a code owner November 23, 2022 13:22
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Nov 23, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 495.9KB 495.8KB -138.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 535d3f8 into elastic:main Nov 24, 2022
@CoenWarmer CoenWarmer deleted the bug/145987-fix-popover-styling-issues-in-ao-pages branch November 24, 2022 08:46
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Pages under Observability App have a styling issue.
4 participants