Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping EUI to version 64.0.4 #140323

Merged
merged 29 commits into from
Sep 20, 2022
Merged

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    59e4cc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    48b21e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b24a0d2 View commit details
    Browse the repository at this point in the history
  3. Deprecate basic usages of getBreakpoint

    - in favor of useCurrentEuiBreakpoint
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    4e37eca View commit details
    Browse the repository at this point in the history
  4. [Fleet] Deprecate isWithinMaxBreakpoint

    - in favor of hook
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    5409753 View commit details
    Browse the repository at this point in the history
  5. [DataViz] Update DataVisualizerTable to use window breakpoint vs tabl…

    …e resize observer
    
    - since getBreakpoint is now deprecated, we're only looking at the current EUI breakpoint (based off window width)
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    4e60ce2 View commit details
    Browse the repository at this point in the history
  6. [KibanaThemeProvider] Allow apps to modify the default EUI theme

    - Setup for custom xl+ breakpoint sizes used by APM and Synthetics
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    652bcf2 View commit details
    Browse the repository at this point in the history
  7. [APM] Update useBreakpoints hook with EUI breakpoint deprecations

    - since getBreakpoint is no longer an usable util
    
    - EUI's new breakpoint hooks already use/debounce window resize events, so we now get to skip all that custom logic by simply making custom EUI breakpoint overrides and using EUI breakpoint hooks
    
    - remove returned `breakpoint` and `width` keys - they weren't actually being used anywhere in APM that I could see and were causing type errors.
    - If someone wants to access them, they can use `useCurrentEuiBreakpoint` and `useWindowSize` individually instead
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b24bc95 View commit details
    Browse the repository at this point in the history
  8. [UX] Update useBreakpoints hook copied from APM

    - basically the exact same logic, they just also need the xxl and xxxl breakpoints
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    a371dac View commit details
    Browse the repository at this point in the history
  9. [Synthetics] Remove useBreakpoints in favor of new EUI breakpoint h…

    …ooks
    
    + add xxl and xxxl breakpoints to Synthetics EUI themes
    
    - `useBreakpoints`: - as far as I can tell, all attached APIs are basically the same APIs that EUI provides OOTB:
      - up -> `useIsWithinMinBreakpoint`
      - down -> `useIsWithinMaxBreakpoint`
      - between -> `useIsWithinBreakpoints`
      - debouncedWidth - not used, but could just use `useWindowSize` directly instead
    
    - note: i'm confused by the `xl` override/conflation with `xxl`, but left the default xl breakpoint size as-is and assumed that all usage instances of 'xl' actually wanted 'xxl'
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    15ec605 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4c91d1e View commit details
    Browse the repository at this point in the history
  11. v64.0.3

    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b8c41d6 View commit details
    Browse the repository at this point in the history
  12. Fix type error from breakpoint deprecation

    - functionally doesn't matter since the array doesn't include undefined, so basically just silence TS complaining about it
    cee-chen committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b4095bb View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    39ac03e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f130f3b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8efa8c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b6725c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Revert "[DataViz] Update DataVisualizerTable to use window breakpoint…

    … vs table resize observer"
    
    This reverts commit 4e60ce2.
    cee-chen committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    958b000 View commit details
    Browse the repository at this point in the history
  2. [DataViz] Remove getBreakpoint usage

    - by replacing the breakpoint logic/switch with custom breakpoint sizes and names
    
    - since the table size can be within panels that don't match `window.innerWidth`, we can't use EUI's breakpoint utils here
    cee-chen committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2aa2234 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Main branch merge.

    1Copenut committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2f96092 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c115b1 View commit details
    Browse the repository at this point in the history
  3. Fix broken side navs on uptime/apm/ux/synthetics

    - because of their new custom xxl/xxxl breakpoints, the `isLargerBreakpoint` logic was broken on the shared solution nav. switching to a min breakpoint bound fixes the issue and futureproofs the solution nav for all apps that add larger breakpoints than xl
    cee-chen committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    cf858f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a196075 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Configuration menu
    Copy the full SHA
    c3c353f View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/tpierce-eui-64.0.1' of github.com:1Copenut/kiba…

    …na into feature/tpierce-eui-64.0.1
    1Copenut committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    eaa2dc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25fc3c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    0ddcf25 View commit details
    Browse the repository at this point in the history
  2. [PR feedback] Separate DataVisualizerTable more clearly from EUI brea…

    …kpoints
    
    - per discussion with Quynh and Walter, there's some confusion around the breakpoints that the table is using. Since the table is width is not always the width of the browser window, it cannot use EUI's breakpoint hooks, and should instead use its own custom map of table-specific breakpoints to make that separation clearer
    cee-chen committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    e6be719 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb45313 View commit details
    Browse the repository at this point in the history