Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Remove empty state from insight accordion #137872

Conversation

janmonschke
Copy link
Contributor

Summary

Since the UI can get quite cluttered with some insight accordions greyed out and some not, we decided (with the design team) to remove the dedicated empty space for now.

Before After
Screenshot 2022-08-02 at 16 57 34 Screenshot 2022-08-02 at 16 49 25

Checklist

@janmonschke janmonschke added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Investigations Team v8.4.0 v8.5.0 labels Aug 2, 2022
@janmonschke janmonschke self-assigned this Aug 2, 2022
@janmonschke janmonschke requested a review from a team as a code owner August 2, 2022 15:03
Since the UI can get quite cluttered with some insight accordions greyed out and some not, we decided (with the design team) to remove the dedicated empty space for now.
@janmonschke janmonschke force-pushed the security/remove-insight-accordion-empty-state branch from 92c142e to a45be47 Compare August 2, 2022 17:21
@janmonschke janmonschke enabled auto-merge (squash) August 2, 2022 17:22
@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.6MB 5.6MB +126.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

@janmonschke janmonschke merged commit 041bd90 into elastic:main Aug 3, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.4:
- [Security Solution] [Analyzer] Use more correct ids from alerts for entity request, clean up some tests (#137370)

Manual backport

To create the backport manually run:

node scripts/backport --pr 137872

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine pushed a commit that referenced this pull request Aug 3, 2022
Since the UI can get quite cluttered with some insight accordions greyed out and some not, we decided (with the design team) to remove the dedicated empty space for now.

(cherry picked from commit 041bd90)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Aug 3, 2022
Since the UI can get quite cluttered with some insight accordions greyed out and some not, we decided (with the design team) to remove the dedicated empty space for now.

(cherry picked from commit 041bd90)

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants