Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fixes Close drilldown flyouts when navigating to dashboard landing page. #136556

Merged
merged 2 commits into from
Jul 20, 2022
Merged

[Dashboard] Fixes Close drilldown flyouts when navigating to dashboard landing page. #136556

merged 2 commits into from
Jul 20, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Jul 18, 2022 •
edited
Loading

Summary

Fixes: #128026

Screen.Recording.2022-07-19.at.10.33.19.mov

@Kuznietsov Kuznietsov added Feature:Dashboard Dashboard related features WIP Work in progress Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting v8.4.0 labels Jul 18, 2022
@Kuznietsov Kuznietsov requested a review from alexwizp July 18, 2022 16:50
@Kuznietsov Kuznietsov self-assigned this Jul 18, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review July 19, 2022 07:35
@Kuznietsov Kuznietsov requested a review from a team as a code owner July 19, 2022 07:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 42.9KB 42.9KB +20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Heenawter Heenawter self-requested a review July 19, 2022 15:39
Heenawter
Heenawter approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally + code review - pretty straight forward change, and it works great 👍

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Jul 19, 2022
@Kuznietsov Kuznietsov removed the WIP Work in progress label Jul 20, 2022
@Kuznietsov Kuznietsov merged commit 049da5a into elastic:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@ThomThomson ThomThomson Awaiting requested review from ThomThomson

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Close drilldown flyouts when navigating to dashboard landing page
4 participants
@Kuznietsov @elasticmachine @kibana-ci @Heenawter