-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Add ability to rerun edited monitor #132639
Conversation
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
14df975
to
0beebb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also send is_edit true in case of disabling monitors, which seems to be triggering a test run !!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Disabled part will be handled on the service side.
Kibana side of things looks good !!
Summary
This PR will cause edited monitors to be rerun immediately.
As discussed on Slack, we decided that simply kicking-off another job was enough to re-run a monitor rather than having a more complex flow to reinstate cronJobs at the right time.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release Note
Immediately re-run monitors in the synthetics service when they're edited.
How to test this PR
Uptime
page. You should soon get results for the edited monitor with the new URL.