Upgrade EUI to v55.0.1 #130593

thompsongl · 2022-04-19T17:39:18Z

Summary

eui@54.0.0 ⏩ eui@55.0.1

EuiPopovers will no longer focus the first tabbable child by default - instead, the popover panel will be focused. This change should be a better experience for both keyboard and screen reader users. Consumers who want to set an initial focus on specific popover element should use the initialFocus prop. (elastic/eui#5784)

hasFocus removed from EuiContextMenuPanel

`55.0.1`

Bug fixes

Fixed missing Sass variable file import (#5820)

`55.0.0`

Added JS function versions of Sass style mixins (a11y, animation, scroll, shadows) (#5754)
Added a <p /> wrapper around description of EuiDescribedFormGroup when provided as a string (#5756)
Added a ratio prop to EuiDescribedFormGroup to control the column width ratio (#5756)

Bug fixes

Fixed margin calculation of hasEmptyLabelSpace on EuiFormRow (#5756)
Fixed vertical alignment between EuiDescribedFormGroup columns (#5756)
Fixed EuiContextMenu stranding keyboard focus when pressing the left/right arrow keys quickly between more than 2 panels (#5783)
Fixed EuiContextMenu to enable up/down arrow key navigation to all focusable items (#5783)
Fixed EuiContextMenu to enable using the up/down arrow keys to navigate to the panel title back button (which takes the user to the previous panel), and focus this button if initialFocusedItemIndex has not been set (#5783)
Fixed EuiComboBox losing focus when a disabled option is clicked (#5795)
Fixed an EuiDataGrid bug occurring when closing cell popovers on clicking the originating cell. The original fix was unintentionally affecting cell popovers with nested modals, popovers, etc. (#5797)

Breaking changes

EuiPopovers will no longer focus the first tabbable child by default - instead, the popover panel will be focused. This change should be a better experience for both keyboard and screen reader users. Consumers who want to set an initial focus on specific popover element should use the initialFocus prop. (#5784)

`54.1.0`

Added EuiTimeline component (#5730)
Added a "subdued" color option to EuiAvatar (#5730)
Added internationalized screen reader helpers to EuiMark (#5739)
Added casesApp feature icon type to EuiIcon (#5779)

Bug fixes

Fixed keyboard focus being stranded on EuiContextMenu popover close (#5760)
Fixed bug in EuiEmptyPrompt where a min-height was unnecessarily being applied for vertical layouts (#5763)

…ut focus - possible race condition failure where cypress is clicking the input too quickly and the popover is stealing focus back onto the panel

cee-chen · 2022-04-20T20:40:21Z

@elasticmachine merge upstream

MadameSheema · 2022-04-21T12:47:39Z

@elasticmachine merge upstream

…eui/55.0

jportner

Spaces changes LGTM

jportner · 2022-04-25T14:04:54Z

x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx

@@ -121,7 +121,6 @@ class SpacesMenuUI extends Component<Props, State> {
        key={`spcMenuList`}
        data-search-term={searchTerm}
        className="spcMenu__spacesList"
-        hasFocus={this.state.allowSpacesListFocus}


Unfortunately, this change broke keyboard navigation for the spaces menu 😔
I don't see a simple change that would fix it, so I opened a separate issue to address that to unblock this PR: #130898

YulNaumenko

Security Solution changes LGTM

peteharverson

For ML @thompsongl can you work with @qn895 please to find a solution for the context menu in the anomalies table?

Also the change in default focus behavior for EuiPopover means we want to set initial focus in a couple of popovers on the Settings - Filter lists - Edit / Create form - the 'add item' and 'edit description' popovers in https://github.com/elastic/kibana/tree/main/x-pack/plugins/ml/public/application/settings/filter_lists/components. Could the initialFocus property be added to those two popovers as part of this PR?

x-pack/plugins/ml/public/application/components/anomalies_table/links_menu.tsx

thompsongl · 2022-04-26T16:48:33Z

@elastic/security-onboarding-and-lifecycle-mgt @elastic/security-detections-response-rules @joeypoon @parkiino

Not sure what combination of y'all are needed to resolve codeowner requirements, but please review! Thanks!

justinkambic

Uptime changes LGTM

thompsongl · 2022-04-27T14:59:40Z

@elasticmachine merge upstream

peteharverson

Tested latest changes for the ML context menus and LGTM. Thanks for making those changes @qn895 @constancecchen

thompsongl · 2022-04-27T16:03:00Z

@elastic/kibana-app-services @elastic/security-detections-response-rules @parkiino

I think your reviews are all for snapshots, so I'm going to ask ops to merge this later today.

cee-chen · 2022-04-27T17:57:24Z

@elasticmachine merge upstream

kibana-ci · 2022-04-27T19:16:44Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.3MB	3.3MB	+182.0B
`security`	491.6KB	491.6KB	-41.0B
`securitySolution`	4.8MB	4.8MB	-11.0B
`spaces`	284.5KB	284.4KB	-41.0B
total			+89.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	288.4KB	288.6KB	+210.0B
`kbnUiSharedDeps-css`	594.5KB	594.5KB	-9.0B
`kbnUiSharedDeps-npmDll`	4.8MB	4.8MB	+8.0KB
total			+8.2KB

History

💔 Build #40919 failed 35bd584
💚 Build #40667 succeeded c9b0331
💔 Build #40651 failed df16c89
💛 Build #40213 was flaky 5a839d6
💚 Build #39868 succeeded 316036c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant

App services data_view_editor lgtm

* eui to v55.0.0 * remove jest polyfill * i18n tokens * hasFocus prop * eui to v55.0.1 * removed obsolete mixin arg * i18n snapshots * hasFocus snapshots * formRow snapshots * euiAvatar snapshots * euiContextMenu snapshot * update focus * hasFocus snapshots * [Security] wait for popover panel focus before checking for field input focus - possible race condition failure where cypress is clicking the input too quickly and the popover is stealing focus back onto the panel * Fix ML focus issue in Filter settings * Fix jest tests * [ML] Fix stale / loading EuiContextMenuPanel item * Fix ML watched props for EuiContextMenuPanel Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>

thompsongl added 4 commits April 19, 2022 11:47

eui to v55.0.0

6f9acec

remove jest polyfill

0d4a983

i18n tokens

7c21af6

hasFocus prop

78565e5

thompsongl added release_note:skip Skip the PR/issue when compiling release notes EUI ci:deploy-cloud v8.3.0 labels Apr 19, 2022

thompsongl added 4 commits April 19, 2022 12:39

Merge branch 'main' into eui/55.0

eb4ce7f

eui to v55.0.1

3abade2

removed obsolete mixin arg

52ea9e2

Merge branch 'main' into eui/55.0

b2890c5

thompsongl changed the title ~~Upgrade EUI to v55.0.0~~ Upgrade EUI to v55.0.1 Apr 19, 2022

thompsongl and others added 13 commits April 19, 2022 16:29

Merge branch 'main' into eui/55.0

e868b20

i18n snapshots

55bc1a4

hasFocus snapshots

64730eb

formRow snapshots

19e478e

euiAvatar snapshots

580b80a

euiContextMenu snapshot

05927dc

Merge branch 'main' into eui/55.0

7c7bce9

update focus

b579ac8

Merge branch 'main' into eui/55.0

1150f6d

hasFocus snapshots

edae992

Merge branch 'main' into eui/55.0

6d526ad

[Security] wait for popover panel focus before checking for field inp…

9400542

…ut focus - possible race condition failure where cypress is clicking the input too quickly and the popover is stealing focus back onto the panel

Merge remote-tracking branch 'upstream/main' into eui/55.0

1339896

Merge branch 'main' into eui/55.0

31c1776

Merge branch 'main' into eui/55.0

5429aa0

Merge branch 'eui/55.0' of https://github.com/thompsongl/kibana into …

5a839d6

…eui/55.0

thompsongl requested a review from a team as a code owner April 25, 2022 13:39

jportner mentioned this pull request Apr 25, 2022

Spaces menu keyboard and screen reader navigation is broken #130898

Closed

jportner approved these changes Apr 25, 2022

View reviewed changes

YulNaumenko approved these changes Apr 26, 2022

View reviewed changes

peteharverson requested changes Apr 26, 2022

View reviewed changes

x-pack/plugins/ml/public/application/components/anomalies_table/links_menu.tsx Outdated Show resolved Hide resolved

miukimiu mentioned this pull request Apr 26, 2022

[ILM] Update edit policy form to use EuiTimeline instead of EuiComment #130302

Closed

justinkambic approved these changes Apr 26, 2022

View reviewed changes

joeypoon approved these changes Apr 26, 2022

View reviewed changes

ryankeairns approved these changes Apr 26, 2022

View reviewed changes

qn895 and others added 3 commits April 26, 2022 12:42

Fix ML focus issue in Filter settings

df16c89

Fix jest tests

11455c8

[ML] Fix stale / loading EuiContextMenuPanel item

c9b0331

kibanamachine and others added 2 commits April 27, 2022 09:59

Merge branch 'main' into eui/55.0

360f27c

Fix ML watched props for EuiContextMenuPanel

35bd584

peteharverson approved these changes Apr 27, 2022

View reviewed changes

Merge branch 'main' into eui/55.0

f017309

jbudz merged commit e615007 into elastic:main Apr 27, 2022

kibanamachine added the backport:skip This commit does not require backporting label Apr 27, 2022

academo mentioned this pull request Apr 29, 2022

Use new cases app icon #131244

Merged

Dosant reviewed May 2, 2022

View reviewed changes

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v55.0.1 #130593

Upgrade EUI to v55.0.1 #130593

thompsongl commented Apr 19, 2022 •

edited

Loading

cee-chen commented Apr 20, 2022

MadameSheema commented Apr 21, 2022

jportner left a comment

jportner Apr 25, 2022

YulNaumenko left a comment

peteharverson left a comment

thompsongl commented Apr 26, 2022 •

edited

Loading

justinkambic left a comment

thompsongl commented Apr 27, 2022

peteharverson left a comment

thompsongl commented Apr 27, 2022 •

edited

Loading

cee-chen commented Apr 27, 2022

kibana-ci commented Apr 27, 2022

Dosant left a comment

Upgrade EUI to v55.0.1 #130593

Upgrade EUI to v55.0.1 #130593

Conversation

thompsongl commented Apr 19, 2022 • edited Loading

Summary

55.0.1

55.0.0

54.1.0

cee-chen commented Apr 20, 2022

MadameSheema commented Apr 21, 2022

jportner left a comment

Choose a reason for hiding this comment

jportner Apr 25, 2022

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

thompsongl commented Apr 26, 2022 • edited Loading

justinkambic left a comment

Choose a reason for hiding this comment

thompsongl commented Apr 27, 2022

peteharverson left a comment

Choose a reason for hiding this comment

thompsongl commented Apr 27, 2022 • edited Loading

cee-chen commented Apr 27, 2022

kibana-ci commented Apr 27, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Dosant left a comment

Choose a reason for hiding this comment

thompsongl commented Apr 19, 2022 •

edited

Loading

`55.0.1`

`55.0.0`

`54.1.0`

thompsongl commented Apr 26, 2022 •

edited

Loading

thompsongl commented Apr 27, 2022 •

edited

Loading